unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Philip Kaludercic <philipk@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA] A Setup package
Date: Mon, 15 Mar 2021 00:15:47 -0400	[thread overview]
Message-ID: <jwv1rchxdf8.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87pn01gv98.fsf@posteo.net> (Philip Kaludercic's message of "Mon,  15 Mar 2021 00:39:47 +0100")

>>> Why use help--make-usage at all?
>> To avoid reinvent the wheel.
> I could reduce it to
>
>         (mapcar (lambda (arg)
>                   (if (string-match "\\`&" (symbol-name arg))
>                       arg
>                     (intern (upcase (symbol-name arg)))))
>                 (get sym 'setup-signature))
>
> which does the job.

Sounds good (but it still shows there's a need for Emacs to provide
a function that does that).

>>> It might be better to save the specification in a separate variable and
>>> modify this destructively for every setup-define call, so as to avoid
>>> the overhead of redefining the entire specification all the time.
>>
>> I wouldn't bother, no.  In the patch below I instead did the
>> spec-processing when setting `setup-debug` (and I also dropped the
>> `none` support because I don't see what it gains: for a macro that
>> takes no arguments, `&rest sexp` works as well).
>> And there is a better option for Emacs-28 and after.
>
> The reason I introduced `none` was that :hide-mode is not repeatable and
> has no arguments, resulting in the edebug specification
>
>     (":hide-mode" sexp)
>
> However this always fails to match.

Indeed that was wrong.  Same problem for non-repeatable macros with more
than one argument.  But in the code I sent in the last message I fixed
this by always using `&rest sexp` for those Setup macros without debug
spec (just like Edebug for normal macros).


        Stefan




  reply	other threads:[~2021-03-15  4:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 11:43 [ELPA] A Setup package Philip K.
2021-02-04 11:47 ` Philip K.
2021-02-09 21:56 ` Stefan Monnier
2021-02-09 23:42   ` Philip K.
2021-03-11 16:17     ` Philip Kaludercic
2021-03-13 19:14       ` Stefan Monnier
2021-03-13 19:44         ` Philip Kaludercic
2021-03-14 15:07           ` Stefan Monnier
2021-03-14 16:21             ` Philip Kaludercic
2021-03-14 20:19               ` Stefan Monnier
2021-03-14 23:39                 ` Philip Kaludercic
2021-03-15  4:15                   ` Stefan Monnier [this message]
2021-03-15 10:09                     ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1rchxdf8.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).