From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Lazy wdired preprocessing Date: Sat, 27 Mar 2021 22:00:08 -0400 Message-ID: References: <87wntuzv7m.fsf@web.de> <87h7kyh9w7.fsf@web.de> <874kgwuph5.fsf@web.de> <87tuow82ih.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22381"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Arthur Miller , emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 28 04:01:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQKjm-0005kq-BH for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Mar 2021 04:01:10 +0200 Original-Received: from localhost ([::1]:46158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQKjl-0000fF-Bm for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Mar 2021 22:01:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQKis-00006C-46 for emacs-devel@gnu.org; Sat, 27 Mar 2021 22:00:14 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61424) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQKiq-00017W-BV for emacs-devel@gnu.org; Sat, 27 Mar 2021 22:00:13 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 22EBE804EC; Sat, 27 Mar 2021 22:00:11 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9B8BA805CE; Sat, 27 Mar 2021 22:00:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616896809; bh=n/9OiCDXVUKv7b5w+RpkhdPEJPwVWcEGiaxM91iNJHc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IjTuUqJZejFdCIu25bPTSqyU8RjMolekoj5GlIRAcPOgF7C36vfchMF4MHvphl2D4 h/6RDyNufgUn7ty2P5w14B8fI10voeJVmUs2XkrtQ84vf/diB7Rf+UiW3GOjphJPCp 2VTbQPJa5hp+XSejsUMFg2lmdzHa6boIKV04qiLUP/pWAZqpuQOzB258cPVZEh5Olc RzJ9i5rMIZbXDGnpEiU2ovKdflCyP+B0iMqTCXhc6bIYpyhqSWeGz8RV+7Jh3TxxMc ikvGwfU5X/9HWY/C1F0LiSwJTa+06MWYppYRezxrJffrUyO/qV8Bo+vasWoVPJAsgD yRW3o7TuG19uA== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 411C2120325; Sat, 27 Mar 2021 22:00:09 -0400 (EDT) In-Reply-To: <87tuow82ih.fsf@web.de> (Michael Heerdegen's message of "Sun, 28 Mar 2021 03:56:22 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267128 Archived-At: >> That's odd. The way I read the code, if you `wdired-abort` then it just >> restores the original contents of the buffer and doesn't look at the >> actual files at all. > Ok, true. My problem is that this loses window points when the buffer > is displayed in several windows, but that might be a minor problem for > others. That should be easy enough to fix. I'd recommend you `M-x report-emacs-bug` (and then post a patch to fix it ;-) E.g. you could use undo to recover the original contents, which should also recover the original `window-point`s. Stefan