From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Speed up project-kill-buffers Date: Mon, 03 May 2021 08:46:08 -0400 Message-ID: References: <87mttcgnke.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16638"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 03 14:50:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldY1t-0004FA-WF for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 14:50:30 +0200 Original-Received: from localhost ([::1]:54548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldY1t-0007Km-19 for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 08:50:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldXxp-0003sc-Iv for emacs-devel@gnu.org; Mon, 03 May 2021 08:46:18 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11898) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldXxm-0000t6-Ck for emacs-devel@gnu.org; Mon, 03 May 2021 08:46:16 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C977A4407D9; Mon, 3 May 2021 08:46:11 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A76774407AB; Mon, 3 May 2021 08:46:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620045970; bh=ZcsYLwBsWat6dtYoobVoW8D8vsg6hxKk7gU2ASpE52k=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eRYFi58Eg8h1IWz3MAEamVwdPV4HaRV2JRV65cKSNe/EVxFDY7SbtJ4MA2Iz+/Dsb udwT+yN3LLfEcUdeyELvO0C+aojJt/cuh2Td6f9Mk6my74L/EX0J/aMdF1tPziiAmX NpYtbq6ThudWyGLNQIt4VPtmDOxnpfMZBbuBj2Qtm6bSBpgQXVH4tim/ppQxM/BNeT 4xhf0jzSyoqEU0sQ9JMRtNJTSoePAm5ErSUkuTsq78lv3D1v3ycRYPFps3vaY5D23d Es11neIKQB/yO0Wei7InKTMl2rwiMLlB+C4U3htC4ce5wRYySGHUbE8UdfOrMzSQpU 0klrhH7fXgj7A== Original-Received: from alfajor (unknown [108.161.125.61]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6FE051202C5; Mon, 3 May 2021 08:46:10 -0400 (EDT) In-Reply-To: <87mttcgnke.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 03 May 2021 11:43:13 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268809 Archived-At: > (defun project--buffer-list (pr) > "Return the list of all buffers in project PR." > - (let (bufs) > + (let ((remote-project-p (file-remote-p (project-root pr))) > + bufs) > (dolist (buf (buffer-list)) > - (when (equal pr > - (with-current-buffer buf > - (project-current))) > + (when (and (let ((remote (file-remote-p (buffer-local-value 'default-directory buf)))) > + (if remote-project-p remote (not remote))) > + (equal pr > + (with-current-buffer buf > + (project-current)))) > (push buf bufs))) > (nreverse bufs))) How 'bout using `file-in-directory-p`? Stefan