From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Do shorthands break basic tooling (tags, grep, etc)? (was Re: Shorthands have landed on master) Date: Fri, 08 Oct 2021 08:58:55 -0400 Message-ID: References: <16338bdc2497fc51c6fb6d54ab370bfb@webmail.orcon.net.nz> <834ka4k15m.fsf@gnu.org> <83y27gijmz.fsf@gnu.org> <8335pmgnjy.fsf@gnu.org> <604da2cb10ac61f2b8b89a02c89056be@webmail.orcon.net.nz> <83a6jtff87.fsf@gnu.org> <5ac7a31cf2959c31c262a3377c736a5a@webmail.orcon.net.nz> <83ilygew7p.fsf@gnu.org> <83fstjdiwl.fsf@gnu.org> <871r534s2o.fsf@gmail.com> <87sfxgx09x.fsf@gmail.com> <83a6jkyrok.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29064"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= , psainty@orcon.net.nz, acm@muc.de, rms@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 08 15:00:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYpTk-0007HY-BN for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Oct 2021 15:00:00 +0200 Original-Received: from localhost ([::1]:53688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYpTj-000576-ER for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Oct 2021 08:59:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYpSp-0004PC-Az for emacs-devel@gnu.org; Fri, 08 Oct 2021 08:59:03 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYpSn-0003q7-G8; Fri, 08 Oct 2021 08:59:02 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E3A9F80531; Fri, 8 Oct 2021 08:58:58 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F41AB801B5; Fri, 8 Oct 2021 08:58:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1633697938; bh=oPGcMd4gWMyPyR/X7ArZrNT/LB/7vw81hePJtnE4Aaw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EriH3hcKcsC/gH8QkAFt/ihXT7i/u2Ym96DLM1QdKpqya4nQJvK/9/Xgsspgxomi9 9XmqDB6KdkCl8AR+yOGclY5sQhBi2yoUHzGCYGZaue3Q2jTiISPYwdCbIwb8XarYf6 sj4ZfQeoqnSIX4Os3glR2xDVf6vVrKyLDJboiEOZJZWRd97rVKu5ipSYJqAFTpN6Cv 2+GBtc+OtQWoW8ZeDNZ2jMBCzr1oSuugGe5YMIIYbDzFogwTo6w8BTEAVzdUYLJdWT WiUJX0oAhoZMeB7MiOiHpFusUIjzTc35l5d/gVNOK/djDWoKPnYsLMJ8n7LrFEotF4 poJdJ+sw8jB5Q== Original-Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A07B21203BC; Fri, 8 Oct 2021 08:58:57 -0400 (EDT) In-Reply-To: <83a6jkyrok.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Oct 2021 09:08:27 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276559 Archived-At: >> An implementation of this idea is awaiting comments over at bug#50959. > I think you should install that. I'm not sure if he may be referring to another patch (I haven't checked the whole thread), but the patch I saw in there implements it with an ad-hoc `completion-style`. I consider this as an abuse of the notion of completion style (which are supposed to be orthogonal to the actual completion data), so I'd strongly recommend not to use this patch. I could agree to the use of a new completion-style for it, but then the code of the completion style should not be specific to `read-symbol-shorthands`. Instead it should offer a generic feature usable by other completion tables (and the part specific to `read-symbol-shorthands` would be in the completion table of `C-x o` rather than in the completion style code). Stefan