From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Duplicated outline-cycle binding, and problems with the new one Date: Wed, 05 Jan 2022 14:21:59 -0500 Message-ID: References: <9DFDAD07-DBC0-4FAE-A565-D1EE6045E7D8@gmail.com> <86ilv25714.fsf@mail.linkov.net> <86pmp6cohf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25786"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Yuan Fu , Emacs developers To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 05 20:29:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5ByK-0006LZ-0y for ged-emacs-devel@m.gmane-mx.org; Wed, 05 Jan 2022 20:29:20 +0100 Original-Received: from localhost ([::1]:39628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5ByH-0005kR-Ms for ged-emacs-devel@m.gmane-mx.org; Wed, 05 Jan 2022 14:29:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5BrL-0007cU-Mm for emacs-devel@gnu.org; Wed, 05 Jan 2022 14:22:11 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:65375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5BrI-0000bj-BX for emacs-devel@gnu.org; Wed, 05 Jan 2022 14:22:05 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 41CFE441D75; Wed, 5 Jan 2022 14:22:02 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 00AE4441D06; Wed, 5 Jan 2022 14:22:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641410521; bh=pkPxeVlnbPiGtMWAfbkahgZCiI6QiqW8oiRc9QTG1xg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=TaiuwM6h2yr+aqoNNV11JpKNKSJDGV1bjo5qSNrjgoKyDi50xgQJY/p7YB1qgyxFc UxWLqdeKwVFx9D5/XQbzjO/4LMaMhdU2PHOeNERr9ewpLyRb2QhpgtXzAO9MhyFo+b Hndg4Ys8FOIDhUqxOaGgBz9Z2S2WMACtBro9BptFcy9tQp0Ecnv2BbTA1u+As/gHkL AMVbqaxdC4ATvPKInRVNKuOWBaMBp1LoWTNELuz0HtffCDi74ZAZEZcE4sG+/w47nq JpaBfudhbKa3RWNFnjqaldcKfKWb+tM4/lUQa1/BwWAwrOgihIEFidBjNUp2K/e18N CigJAzENXwbPw== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9A8D612025D; Wed, 5 Jan 2022 14:22:00 -0500 (EST) In-Reply-To: <86pmp6cohf.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 05 Jan 2022 20:35:56 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284270 Archived-At: > But diff-mode overrides this binding with diff-mode-shared-map > where the TAB key is bound to diff-hunk-next, since > minor-mode-overriding-map-alist takes priority over > minor-mode-map-alist when diff-mode does this: I see. I knew using `minor-mode-overriding-map-alist` in `diff-mode.el` this way was going to bite us sooner or later. Maybe we should use a hook on `read-only-mode` to set/unset a `diff-mode-read-only` variable so we can add the keymap (conditionalized on this new `diff-mode-read-only`) to `minor-mode-map-alist` instead of `minor-mode-overriding-map-alist`. Stefan