From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Colorful line numbers Date: Fri, 22 Jul 2022 19:32:06 -0400 Message-ID: References: <87leslpow2.fsf@gmail.com> <2aabd319-8e8c-72dd-3143-45de9172dc54@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7665"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 23 01:33:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oF28m-0001rX-UJ for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jul 2022 01:33:05 +0200 Original-Received: from localhost ([::1]:55414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oF28l-0005np-Lz for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Jul 2022 19:33:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oF27x-00056G-9I for emacs-devel@gnu.org; Fri, 22 Jul 2022 19:32:13 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10137) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oF27u-0003H2-OZ for emacs-devel@gnu.org; Fri, 22 Jul 2022 19:32:12 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7122D4417B6; Fri, 22 Jul 2022 19:32:09 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CED9B44179B; Fri, 22 Jul 2022 19:32:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1658532727; bh=w1bpriXszXoDBjZkqdxRN94cNvOQxgcmLtV0WwWDIO8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NaYTDDqUMeTDvTL5230FFhkaHVj62awNl0bjWSPyuVrjY8nNLg+9n0CE0QaUUaSmJ NnpedZFXE8kPit+A1ITyOSD21NOZirkExUFSE4ibMEHpxz3KdUsLQV8aqM7OjkSrrk GzjKx1PAKIJThBxIoPynsHs4HzkN/8HuSys+qnfh2dInbXXVT1m1r3TXt44j9puShu fo31ev/EKdXU/TatW6MU5bFttisDKa1DHulOhNAQEMpzWWJGd4UTzBsCVf/Z8z8Ct9 uiKCMlY5m2CNy6XjA3o5t9QxgKBMQLynqPHbtbjJCCJbO+a1D4bTO5+DuqHXrr12w5 m6gOdTicR6nYg== Original-Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 96FD0120312; Fri, 22 Jul 2022 19:32:07 -0400 (EDT) In-Reply-To: <2aabd319-8e8c-72dd-3143-45de9172dc54@yandex.ru> (Dmitry Gutov's message of "Fri, 22 Jul 2022 16:41:51 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292491 Archived-At: >>> Also seehttps://debbugs.gnu.org/36472. >> Have you tried to add such a feature for `(n)linum-mode`? > I didn't: that's not what the diff-hl user was asking for. But you could add that feature to `diff-hl` for `(n)linum-mode` so people can at least try it out. > But I proposed several different technical approaches, every one of which > has been rejected so far. And not because of the difficulty > of implementation. > > Not sure how implementing any of them in nlinum would help, given that the > primary complaint was about running Lisp. I suspect the problem is not "running Lisp" but "running Lisp from the code that implements `display-line-numbers-mode`", because that code is deep in the redisplay where running Lisp code can be tricky. That same problem does not apply to `(n)linum-mode` because their code is not "deep in redisplay". > And if we take an alternative approach (display-line-numbers-mode looks up > text properties in the buffer to determine which face to use), it also > depends on the intricacies of its implementation. E.g. how to reliably > redraw when such text properties change. My hunch is that such changes to text-properties would cause a rerendering of those lines anyway (the decision whether to re-render doesn't pay attention to which properties have been changed, IIRC), so it may end up "just working" without any effort in this respect. Then again, maybe not. Stefan