From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: noverlay branch Date: Thu, 13 Oct 2022 00:03:45 -0400 Message-ID: References: <87sfjzefvv.fsf@rfc20.org> <875ygt6gbj.fsf@rfc20.org> <87pmf04c7s.fsf@rfc20.org> <87sfjvvx7g.fsf@rfc20.org> <87fsfuw85t.fsf@rfc20.org> <87czaxwreu.fsf@rfc20.org> <87ilkollu5.fsf@rfc20.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23603"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Matt Armstrong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 13 06:07:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oipV3-0005wF-O3 for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Oct 2022 06:07:13 +0200 Original-Received: from localhost ([::1]:42904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oipV2-0004VF-DW for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Oct 2022 00:07:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oipRo-0002lA-Hu for emacs-devel@gnu.org; Thu, 13 Oct 2022 00:03:52 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47775) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oipRl-00084Q-Hl for emacs-devel@gnu.org; Thu, 13 Oct 2022 00:03:50 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DBF9B807C3; Thu, 13 Oct 2022 00:03:47 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 71FED805B1; Thu, 13 Oct 2022 00:03:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1665633826; bh=ZHg4pJ4cr11EFuKVtJxBkO/VJWTtoqBYKmE2epHPXZQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=c6ax0ekmlaPhEQMwICWurDcAzNeR55epYDN34M3R/z1EN0NMPIqZukwmsSU9iPP9E 30XEq0s5eh1eQgY1hTLb6epXy7p3nx/39i9VFUMf3iA5tRSM+3sj7x8/Qck1SZjjtK P1lRiLo2YbTcRvsyVQyKpvcs2eLuNGkA4Tbz0EomCxtd3lVFiFk1jgFplRqp8NYA9q JRGKfum9O4DoHxpNwgoioaLF/n+fH1dLKXiS5D6JcZyktXPGHvMcIcF7kNHRqUIuHn dCWuWuaBKE32evSBnPa5hC1+mPDSKzZufPkl4OwOC4djaXUsdoblf/uiOkLiU0Q23/ 1ciB8sRMn3eHw== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 48AAC120F37; Thu, 13 Oct 2022 00:03:46 -0400 (EDT) In-Reply-To: <87ilkollu5.fsf@rfc20.org> (Matt Armstrong's message of "Wed, 12 Oct 2022 15:26:58 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297651 Archived-At: > As a practical matter, `interval_tree_insert_fix` asserts it, and that > was failing for me. I wanted it to fail earlier. Ah, I see we depend on it in our implementation of insertion. OK. Then maybe it's best to keep this assertion in the insertion code or at least add a node explaining why we require it. > I'm inclined to keep it the way it is, if only for reasons of inertia. I have no trouble with it, indeed. It's just subtle enough to warrant a comment. Stefan