From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/package-vc has been merged Date: Wed, 09 Nov 2022 16:21:22 -0500 Message-ID: References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <83y1soypvx.fsf@gnu.org> <87y1song5x.fsf@posteo.net> <83v8nsyof7.fsf@gnu.org> <87leoond7l.fsf@posteo.net> <83r0yfzz01.fsf@gnu.org> <87bkpjyx3p.fsf@posteo.net> <83bkpjynmj.fsf@gnu.org> <87iljqya44.fsf@posteo.net> <8335auzo9s.fsf@gnu.org> <87zgd2ws8z.fsf@posteo.net> <831qqezkxj.fsf@gnu.org> <87y1slgq3m.fsf@posteo.net> <87bkpgfsqv.fsf@posteo.net> <87educ9fei.fsf@posteo.net> <8735as9cfb.fsf@posteo.net> <87pmdv98du.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17095"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , rms@gnu.org, emacs-devel@gnu.org, Lars Ingebrigtsen To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 09 22:30:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osseq-0004F5-6J for ged-emacs-devel@m.gmane-mx.org; Wed, 09 Nov 2022 22:30:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osseL-0007e6-PO; Wed, 09 Nov 2022 16:30:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osseK-0007dy-Cp for emacs-devel@gnu.org; Wed, 09 Nov 2022 16:30:20 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osseI-0004Oz-LV; Wed, 09 Nov 2022 16:30:20 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2BA914414D4; Wed, 9 Nov 2022 16:21:25 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 69C7C4414D0; Wed, 9 Nov 2022 16:21:23 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1668028883; bh=5pcJlg6Gjhi1oHfNxZAmMIxaD7k4XcchsD61juCH3l8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=YjdZxcnNtW2fpiH8i2Hy/aLqYNqhB8RsO47pXwz0hkWjpEdzTO8BnJUU/ZQ/hRRk1 PjzrDdI38Atl8XDMM+QuEVmouOL56c5Gfq78RlXVJPe+/QtgwthTpuOrSoDafNdYvb Yd45mRv7ho4fdUH1ig24/VGBYhYmO5IZ8hTmurKmW42cnc2AQx4362Q5YZZW+m0hDX mpxeRHqdkkrR1ZE7RqSGmz/kKgOGP5s6qvebi28LRn8Bfg33cSQ+FjLrEdI6/cFzQm gOWKaQjKSyyrLJJYhqQM7UF09DWvOc/aPNtCIWGYb4QLT9UPoH/4k7ddpaMg76LnFA kdNpVyW725O5w== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 58225120B09; Wed, 9 Nov 2022 16:21:23 -0500 (EST) In-Reply-To: <87pmdv98du.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 09 Nov 2022 20:32:13 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299439 Archived-At: >> But for `package-vc` that's already the case since it has complete control >> over how the `-pkg.el` and the `-autoloads.el` are generated. > > ..., this is handled by `package-vc--unpack-1' which up until now did > not depend on a package specification, just a package description. This > is so, so that it can be invoked by `package-vc-refresh' or > `package-vc-install-from-checkout' which all don't necessarily have > specifications. It would be imaginable to store the specification in a > file like -spec.eld, but there are too many files already so this > is just getting more and more messy. > > If you believe that this is not worth it or shortsighted on my part, > I'll implement the code necessary for what you suggest to work. Ah... so this is extra info stored in the `-pkg.el` file but only for packages installed by `package-vc`. So it's not expected to appear in `-pkg.el` coming from ELPA repositories. But then it should not be used in `package.el`, only in `package-vc-...` functions, right? BTW, I'm beginning to sense that maybe instead of storing `:lisp-dir` in the package description (of package-vc-installed-packages), we should/could store there the whole package-spec. This way `package-vc-refresh` can use the package-spec and throw away the rest of the package description. For `package-vc-install-from-checkout`, we need to "invent" a package spec anyway, right? Stefan