From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/meow 9860a7a218: Correct unused lexical variable (#411) Date: Fri, 10 Mar 2023 14:43:06 -0500 Message-ID: References: <167841008488.32504.7948735471580268728@vcs2.savannah.gnu.org> <20230310010125.5A435C13A88@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26963"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Campbell Barton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 10 20:43:36 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paieN-0006qQ-Sn for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Mar 2023 20:43:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paie2-0007Ui-Cu; Fri, 10 Mar 2023 14:43:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paie0-0007L2-FJ for emacs-devel@gnu.org; Fri, 10 Mar 2023 14:43:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paidz-0002t3-0G for emacs-devel@gnu.org; Fri, 10 Mar 2023 14:43:12 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8BDE110009E; Fri, 10 Mar 2023 14:43:09 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8ED411000BD; Fri, 10 Mar 2023 14:43:07 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1678477387; bh=dlLW8txoU+Iuxt0sfj07yMwj7KN27NkX1iGNc0JD4PQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=b2G6nTkZIMKGco5PnfW7liTK5Mw4xDaiVwEHlAMjOIM81wZOJmrM83PYYjbtcT/Zp 6eHPP157Cw0PZTdtCN46XPzcfAGl7ipW8Cj3p3qb8jlv7lvBeZuKoRvXfl+Jwg9fIn KgKfQiD0ulf+mz+aNvb0YJr2BwocELGUFS8hy4euPLhvVUeK8JFgceYFSKuUgY/KS0 CisCNTXSUs4WjvP2m0kWBsixNtS8ClU9LX0Xq21u2ngtDKeK0h3kzQGSpferYmxJj1 GxU8DFcgWhB+CoxYbBQ71SlZFZWopEvd4LvV48Qm1Uhg58rBLT6LNOmem0R0QXoM58 2SgBBtLdPgvBg== Original-Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5A4B61205A2; Fri, 10 Mar 2023 14:43:07 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Fri, 10 Mar 2023 14:40:37 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304256 Archived-At: > Hmm... that doesn't look right: `format-kbd-macro` is like > `key-description`, i.e. it returns a human-readable version of a key > sequence. That is (more or less) the format understood by `kbd` (and > `key-parse`) but is not the format accepted by `key-binding`, which > expects an actual vector of events (which can degenerate to a string if > the events are simple enough). BTW, here's a related patch I've had pending for a while. Stefan diff --git a/meow-command.el b/meow-command.el index 13602c6ffd..d19cb39217 100644 --- a/meow-command.el +++ b/meow-command.el @@ -1178,7 +1178,8 @@ with UNIVERSAL ARGUMENT, search both side." (defun meow-search (arg) " Search and select with the car of current `regexp-search-ring'. -If the contents of selection doesn't match the regexp, will push it to `regexp-search-ring' before searching. +If the contents of selection doesn't match the regexp, will push it to +`regexp-search-ring' before searching. To search backward, use \\[negative-argument]." (interactive "P") @@ -1632,24 +1633,26 @@ This command is a replacement for built-in `kmacro-end-macro'." (setq mouse-secondary-start next-marker) (meow--cancel-selection)))) -(defun meow-describe-key (key-list &optional buffer up-event) +(defun meow-describe-key (key-list &rest args) (interactive (list (help--read-key-sequence))) - (if (= 1 (length key-list)) - (let* ((key (format-kbd-macro (cdar key-list))) - (cmd (key-binding key))) - (if-let ((dispatch (and (commandp cmd) - (get cmd 'meow-dispatch)))) - (describe-key (kbd dispatch) buffer up-event) - (describe-key key-list buffer up-event))) - ;; for mouse events - (describe-key key-list buffer up-event))) + (apply #'describe-key + (if (= 1 (length key-list)) + (let* (;; (key (format-kbd-macro (cdar key-list))) + (cmd (key-binding (cdar key-list)))) + (if-let ((dispatch (and (commandp cmd) + (get cmd 'meow-dispatch)))) + (kbd dispatch) + key-list)) + ;; for mouse events + key-list) + args)) ;; aliases -(defalias 'meow-backward-delete 'meow-backspace) -(defalias 'meow-c-d 'meow-C-d) -(defalias 'meow-c-k 'meow-C-k) -(defalias 'meow-delete 'meow-C-d) -(defalias 'meow-cancel 'meow-cancel-selection) +(defalias 'meow-backward-delete #'meow-backspace) +(defalias 'meow-c-d #'meow-C-d) +(defalias 'meow-c-k #'meow-C-k) +(defalias 'meow-delete #'meow-C-d) +(defalias 'meow-cancel #'meow-cancel-selection) ;; removed commands