From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: pkg-autoloads.el vs. pkg-loaddefs.el Date: Tue, 13 Aug 2024 20:31:45 -0400 Message-ID: References: <87y1adrria.fsf@localhost> <87o77zbs4j.fsf@localhost> <871q4us0l9.fsf@localhost> <87msniqhel.fsf@localhost> <87h6dqqaqp.fsf@localhost> <87h6dp9cde.fsf@localhost> <8734p8aomr.fsf@localhost> <86msngnr73.fsf@gnu.org> <87jzh5fwt5.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34252"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 14 02:32:37 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1se1wL-0008mn-EL for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Aug 2024 02:32:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1se1vg-0003zV-Fl; Tue, 13 Aug 2024 20:31:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se1ve-0003xo-FW for emacs-devel@gnu.org; Tue, 13 Aug 2024 20:31:54 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se1vZ-0000U0-Gw; Tue, 13 Aug 2024 20:31:53 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C69FE444D51; Tue, 13 Aug 2024 20:31:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1723595506; bh=xXh39W8D8e2qycBhSptWSu+iYy1FQCKnpinsV2bwEoI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=UEPMqqBnkaOZXm1gBmoKYvh1/CahKF4ynybFqF2GRHJoH3BtTRWGaMUG7qq6GtZk+ i8lyuDj0CoeiLLUcJ/Sa4XOwA2oBG5XhyLAe5IXD9e5WtrB2yrSDdt8hGcQl+++211 rrnkt4mt74/zG8N3eL257tt/zBPE+W8R4QrknQ8uBknxPQTku/DYtkdu0ak0S09+6i yaDGlWIZlOdwOgW3+cNeCDZf7cvnNPJFCI1tT9WSD276IuELIezMOrzWrLpsabIGBi 0SO1b0/xWtDKJwppWhdBu8j+pbMDS5xqaj+vUyFQIqs5itn9diHtBWNlf18aT2CgdB Le7Osr8Kim+4Q== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5DE74444D53; Tue, 13 Aug 2024 20:31:46 -0400 (EDT) Original-Received: from pastel (unknown [216.154.9.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3358C1204B4; Tue, 13 Aug 2024 20:31:46 -0400 (EDT) In-Reply-To: <87jzh5fwt5.fsf@localhost> (Ihor Radchenko's message of "Sun, 28 Jul 2024 13:52:38 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322721 Archived-At: >>> -(defun package--reload-previously-loaded (pkg-desc) >>> +(defun package--reload-previously-loaded (pkg-desc &optional warn) >>> "Force reimportation of files in PKG-DESC already present in `load-history'. >>> New editions of files contain macro definitions and >>> redefinitions, the overlooking of which would cause >>> -byte-compilation of the new package to fail." >>> +byte-compilation of the new package to fail. >>> +If WARN is a string, display a warning (using WARN as a format string) >>> +before reloading the files." >> >> You say that WARN is treated as a format string, but that begs the >> questions: what are the arguments to be formatted with that string? > > Stefan, do you have any comments? It seems to be the only blocker. It's an internal function, so I think the docstring is verbose enough already. Stefan