From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: pkg-autoloads.el vs. pkg-loaddefs.el
Date: Tue, 13 Aug 2024 20:31:45 -0400 [thread overview]
Message-ID: <jwv1q2st06q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87jzh5fwt5.fsf@localhost> (Ihor Radchenko's message of "Sun, 28 Jul 2024 13:52:38 +0000")
>>> -(defun package--reload-previously-loaded (pkg-desc)
>>> +(defun package--reload-previously-loaded (pkg-desc &optional warn)
>>> "Force reimportation of files in PKG-DESC already present in `load-history'.
>>> New editions of files contain macro definitions and
>>> redefinitions, the overlooking of which would cause
>>> -byte-compilation of the new package to fail."
>>> +byte-compilation of the new package to fail.
>>> +If WARN is a string, display a warning (using WARN as a format string)
>>> +before reloading the files."
>>
>> You say that WARN is treated as a format string, but that begs the
>> questions: what are the arguments to be formatted with that string?
>
> Stefan, do you have any comments? It seems to be the only blocker.
It's an internal function, so I think the docstring is verbose
enough already.
Stefan
next prev parent reply other threads:[~2024-08-14 0:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 12:56 pkg-autoloads.el vs. pkg-loaddefs.el Ihor Radchenko
2024-06-14 13:54 ` Stefan Monnier via Emacs development discussions.
2024-06-17 13:45 ` Ihor Radchenko
2024-06-17 14:04 ` Stefan Monnier
2024-06-18 16:00 ` Ihor Radchenko
2024-06-18 17:23 ` Stefan Monnier
2024-06-18 17:39 ` Ihor Radchenko
2024-06-18 19:43 ` Stefan Monnier
2024-06-18 20:03 ` Ihor Radchenko
2024-06-18 20:12 ` Stefan Monnier
2024-06-19 15:32 ` Ihor Radchenko
2024-06-19 15:58 ` Stefan Monnier
2024-06-19 16:22 ` Ihor Radchenko
2024-06-19 20:35 ` Stefan Monnier
2024-06-20 5:01 ` Eli Zaretskii
2024-07-28 13:52 ` Ihor Radchenko
2024-08-14 0:31 ` Stefan Monnier [this message]
2024-08-14 5:43 ` Eli Zaretskii
2024-06-20 15:33 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1q2st06q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).