From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/transient 667ce2b287 18/23: Use transient-default-value in transient-init-value(suffix) Date: Wed, 25 Dec 2024 09:14:54 -0500 Message-ID: References: <173487507772.3820862.14263838078882905942@vcs3.savannah.gnu.org> <20241222134440.C5563C5C27C@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40272"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Jonas Bernoulli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 25 15:15:47 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tQSAt-000AJT-4a for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Dec 2024 15:15:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQSAO-0000pD-88; Wed, 25 Dec 2024 09:15:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQSAH-0000m3-EW for emacs-devel@gnu.org; Wed, 25 Dec 2024 09:15:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQSAF-0005Ow-Nn for emacs-devel@gnu.org; Wed, 25 Dec 2024 09:15:09 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9F8F210004A; Wed, 25 Dec 2024 09:15:04 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1735136103; bh=bPwSkAGBoh72lNbAQZPa5ytU5FX5Gm5hj9Q14Ys+JPA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GLBNgVoXw9JjvnzSeCb05yKWEuaXhk5ieUem6fV+lMPSaBVi5LMJKDFFPV4y3CQ/Y c/mIZ4bc3WUH/3ojqDvRxCUoB2IMj6ftGc7MaI9V4mXfNMCfGSXC/6bOrDSNom3i6A au1Jbv4GlbLYLnFhS2D96p8WNyxuXQEKWGORplUXzjuUSIzXgfQdpcwAqNjTa1T/Kg WdFGYuTmEjxWgd/PYuY2u3bOP86f2Wsptfq7HBPJMWZOb1Xb3SMzaKpacExUCv8/6/ WTJH3NOj7ceHbuRaPa7EgffyXK8M9VKdDRwqt5rdOvj+0ijvL/jK1vJCcbgWLkDy/o mKIlmKkODeCRA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BD496100035; Wed, 25 Dec 2024 09:15:03 -0500 (EST) Original-Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 95425120550; Wed, 25 Dec 2024 09:15:03 -0500 (EST) In-Reply-To: <20241222134440.C5563C5C27C@vcs3.savannah.gnu.org> (Jonas Bernoulli via's message of "Sun, 22 Dec 2024 08:44:40 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327096 Archived-At: Hi Jonas, > --- a/lisp/transient.el > +++ b/lisp/transient.el > @@ -3331,9 +3331,13 @@ Use `transient-default-value' to determine the default value." > (cdr saved) > (transient-default-value obj))))) > > -(cl-defmethod transient-init-value ((_ transient-suffix)) > - "Non-infix suffixes usually don't have a value, so this is a noop." > - nil) > +(cl-defmethod transient-init-value ((obj transient-suffix)) > + "Non-infix suffixes usually don't have a value. > +Call `transient-default-value' but because that is a noop for > +`transient-suffix', this function is effectively also a noop." > + (let ((value (transient-default-value obj))) > + (unless (eq value eieio--unbound) > + (oset obj value value)))) > > (cl-defmethod transient-init-value ((obj transient-argument)) > "Extract OBJ's value from the value of the prefix object." > @@ -3379,6 +3383,11 @@ that. If the slot is unbound, return nil." > default) > nil)) > > +(cl-defmethod transient-default-value ((_ transient-suffix)) > + "Return `eieio--unbound' to indicate that there is no default value. > +Doing so causes `transient-init-value' to skip setting the `value' slot." > + eieio--unbound) > + > ;;;; Read > > (cl-defgeneric transient-infix-read (obj) Why use `eieio--unbound` (i.e. a variable internal to EIEIO) rather than your own magic placeholder? IOW, is there a good reason to break the abstraction here? Stefan