From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Sat, 20 Jan 2018 20:04:32 -0500 Message-ID: References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <83lggtu1qn.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516496581 10314 195.159.176.226 (21 Jan 2018 01:03:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 Jan 2018 01:03:01 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 21 02:02:57 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ed41z-0001Yv-Ss for ged-emacs-devel@m.gmane.org; Sun, 21 Jan 2018 02:02:44 +0100 Original-Received: from localhost ([::1]:48881 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ed440-0006MV-3R for ged-emacs-devel@m.gmane.org; Sat, 20 Jan 2018 20:04:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ed43t-0006LU-BI for emacs-devel@gnu.org; Sat, 20 Jan 2018 20:04:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ed43s-0000YC-DE for emacs-devel@gnu.org; Sat, 20 Jan 2018 20:04:41 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ed43l-0000TS-9g; Sat, 20 Jan 2018 20:04:33 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ed43k-0006Rn-PF; Sat, 20 Jan 2018 20:04:32 -0500 X-Spook: 2600 Bust Smart Power lines Malware Trojan cybercash Bush X-Ran: ET#]zAEVV%Wdfx-bYw!y{nvDJq?"|_W:-}fNsm.'+MR,q%,#qWY8wlneh+^?:h-NAp&\ (Glenn Morris's message of "Fri, 19 Jan 2018 16:17:25 -0500") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222115 Archived-At: IMO the change in 4fd446e is obviously correct. The current (reverted) code is wrong by inspection when target-file is relative. In normal use, it never is, but it will be if byte-compile-dest-file is changed to return a non-absolute value. For example, this can be the case for automake, as we saw in http://lists.gnu.org/archive/html/emacs-devel/2017-11/msg00551.html since Makefiles normally use relative filenames, and automake changes byte-compile-dest-file-function to return "$@". Eg I predict the following will fail on a FreeBSD system like the one in the original message in this thread: ./src/emacs --batch \ --eval '(setq byte-compile-dest-file-function (lambda (x) "foo.elc"))' -f batch-byte-compile foo.el This simulates how automake may call Emacs to compile a file. (It fails on RHEL 7.4 with TMPDIR=/does/not/exist. Obviously this is not sensible, but the point is that it should not be writing to TMPDIR at all.) I am posting this analysis for completeness, with zero expectation of it changing anything.