From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joaotavora@gmail.com (=?iso-8859-1?Q?Jo=E3o_T=E1vora?=) Newsgroups: gmane.emacs.devel Subject: Re: Getting rid of low-level assumptions in yasnippet Date: Fri, 20 Mar 2015 11:03:20 +0000 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1426849437 30214 80.91.229.3 (20 Mar 2015 11:03:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Mar 2015 11:03:57 +0000 (UTC) Cc: Akira Kitada , Tassilo Horn , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 20 12:03:47 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYuiQ-0006Mz-Kc for ged-emacs-devel@m.gmane.org; Fri, 20 Mar 2015 12:03:46 +0100 Original-Received: from localhost ([::1]:43207 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYuiP-00087y-UZ for ged-emacs-devel@m.gmane.org; Fri, 20 Mar 2015 07:03:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYuiC-00086F-Jd for emacs-devel@gnu.org; Fri, 20 Mar 2015 07:03:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYuiB-0002rU-Gn for emacs-devel@gnu.org; Fri, 20 Mar 2015 07:03:32 -0400 Original-Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:36669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYui6-0002ps-AC; Fri, 20 Mar 2015 07:03:26 -0400 Original-Received: by wgra20 with SMTP id a20so86223155wgr.3; Fri, 20 Mar 2015 04:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=VsfQzCfyUASVLF9wbXcN2o8SEmo4AdatjgXoXo/Xv6A=; b=WCqSCUdZjI/Vm226Qs9CDJIwhty1+tc4GKqF+vpETGFlfKNkgOPQxlgdNcMH+nnmux 7us0rvfmCh8gnVLk6wkMu9eGzDfGZO7Y6Rt2etrok5xkP/uhYlPlvLhJjNqDrJ5frkix o5njYK2qGPg4fH2iQcqeYU6+azK+YNIom7b0Bopaqt0bJUOXsphLPKnCmY34O/m5YHgm l/MTbCYNiXBHf9Y46+Z6NfGtlXuTu96Y5CiDV+8Um9ad0PWyzue04oAzr0uKBG0XYR5I il3UlCKEuXME/IcwLkfC6eIUsrlXIzt+tEbYX0h2V1RVuM4I0aREZzH+Y3HqwzRhdh/f YECQ== X-Received: by 10.194.20.67 with SMTP id l3mr156960028wje.94.1426849405113; Fri, 20 Mar 2015 04:03:25 -0700 (PDT) Original-Received: from GONDOMAR.yourcompany.com (53.236.108.93.rev.vodafone.pt. [93.108.236.53]) by mx.google.com with ESMTPSA id p1sm2487660wib.23.2015.03.20.04.03.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Mar 2015 04:03:24 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Thu, 19 Mar 2015 15:49:59 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (windows-nt) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184034 Archived-At: Stefan Monnier writes: > Could you double check the patch below, to make sure it does the right th= ing? > The main thrust is to get rid of the use of the `cl-struct-slots' > property which doesn't exist in Emacs-25 any more. The patch look good. I've pushed it upstream and it passes all tests. I'm slightly embarassed you have to wade through that junk, but that's how much Lisp I knew at the time. > This is against the elpa.git version of the code, which IIUC is still > not up-to-date, right? Again embarassing: there are two or three issues on the upstream side also pending on this move. I'll try to do this later today. One thing I don't know how to handle is the Git submodules which are problematic for some (unofficial) uses of ELPA.git, such as https://github.com/quelpa/quelpa (CCing akira) So unless you disagree, I'll remove them completely in the subtree merge result and (temporarily) replace yasnippet/snippets with a copy of the old snippet collection. Jo=E3o