From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.orgmode,gmane.emacs.devel Subject: Re: org-export raises stringp nil error Date: Thu, 07 Mar 2013 20:36:33 -0500 Message-ID: References: <87ip539io1.fsf@nautilus.nautilus> <87zjye96ph.fsf@bzg.ath.cx> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1362706624 21264 80.91.229.3 (8 Mar 2013 01:37:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Mar 2013 01:37:04 +0000 (UTC) Cc: Lele Gaifax , emacs-orgmode@gnu.org, emacs-devel@gnu.org To: Bastien Original-X-From: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Fri Mar 08 02:37:28 2013 Return-path: Envelope-to: geo-emacs-orgmode@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UDmFU-0007A4-87 for geo-emacs-orgmode@m.gmane.org; Fri, 08 Mar 2013 02:37:28 +0100 Original-Received: from localhost ([::1]:43660 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDmF7-0002tm-U5 for geo-emacs-orgmode@m.gmane.org; Thu, 07 Mar 2013 20:37:05 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDmEe-0002cR-To for emacs-orgmode@gnu.org; Thu, 07 Mar 2013 20:36:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDmEd-0005iz-Kl for emacs-orgmode@gnu.org; Thu, 07 Mar 2013 20:36:36 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDmEd-0005is-HS; Thu, 07 Mar 2013 20:36:35 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UDmEc-0006VU-3f; Thu, 07 Mar 2013 20:36:34 -0500 X-Spook: Freeh HAMASMOIS Geraldton argus basement Telex Rumsfeld X-Ran: sLMo*R-/p1u*w(r(n{XrNe*p3t`J?$Hz_TczmlVqaqdzn8*N+$J!^/L~gO/RI4{>dt?Fc5 X-Hue: cyan X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Original-Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.orgmode:67886 gmane.emacs.devel:157573 Archived-At: Bastien wrote: > Glenn Morris writes: > >> Assuming this is a recent regression, then if anyone from Org wants this >> fixed in Emacs 24.3, they should investigate this very quickly and >> suggest the _minimum_ change. > > The minimal fix is attached. > > The other attachment is the full patch I wanted to apply to merge > Org 7.9.4 into Emacs 24.3. The changes are all safe bugfixes. > > I assumed it was okay to fix bugs after the last pretest, is it so? No, it is not ok, and I don't know why you would think it is. "Release candidate" means "this IS the release unless something CRITICAL occurs". I hoped my various posts to this list had made this clear. It's also been the traditional policy of at least the more recent Emacs releases as far as I know. I should have been stricter in insisting that Org follow the same policy as everybody else during pretesting, in only installing regression bug fixes. I'm pretty sure this has not been happening, given the size and nature of the changes that keep landing. The reason for this policy is (obviously) to prevent inadvertently introducing mistakes. This seems to be exactly what has bitten us in this case, where your patch just reverts the change from http://lists.gnu.org/archive/html/emacs-diffs/2013-02/msg00058.html Was that fixing a regression? I doubt it. Please apply the first patch as soon as possible. The second includes stuff like deleting comments, declaring functions, and changing autoload for "org-autoload". No, you may not apply this. If there were any fixes in there for important regression bugs against Emacs 24.2, please make a separate patch with just those items.