From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: Change to process.c Date: Sun, 22 May 2005 11:50:10 +0200 Message-ID: References: <17039.61956.135880.754713@farnswood.snap.net.nz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1116756973 15419 80.91.229.2 (22 May 2005 10:16:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 22 May 2005 10:16:13 +0000 (UTC) Cc: hunterd42@comcast.net, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 22 12:16:10 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DZnUb-0006HE-Ew for ged-emacs-devel@m.gmane.org; Sun, 22 May 2005 12:15:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DZnXp-00045S-6m for ged-emacs-devel@m.gmane.org; Sun, 22 May 2005 06:18:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DZnE9-0001Ex-2P for emacs-devel@gnu.org; Sun, 22 May 2005 05:58:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DZnDq-0001AG-Lh for emacs-devel@gnu.org; Sun, 22 May 2005 05:58:15 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DZnDq-000166-D4 for emacs-devel@gnu.org; Sun, 22 May 2005 05:58:14 -0400 Original-Received: from [195.135.220.2] (helo=mx1.suse.de) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1DZnEx-0004kb-3u for emacs-devel@gnu.org; Sun, 22 May 2005 05:59:23 -0400 Original-Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id BC25ADF38; Sun, 22 May 2005 11:50:11 +0200 (CEST) Original-To: Nick Roberts X-Yow: It's so OBVIOUS!! In-Reply-To: (Andreas Schwab's message of "Sun, 22 May 2005 11:34:49 +0200") User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37462 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37462 Andreas Schwab writes: > Nick Roberts writes: > >> gcc -c -D_BSD_SOURCE -Demacs -DHAVE_CONFIG_H -DUSE_LUCID -I. -I/hom= e/nick/emacs/src -D_BSD_SOURCE -I/usr/X11R6/include -g3 process.c >> process.c: In function `send_process': >> process.c:5295: warning: assignment from incompatible pointer type >> process.c:5304: warning: passing arg 2 of `sys_signal' from incompatib= le pointer type >> process.c:5323: warning: passing arg 2 of `sys_signal' from incompatib= le pointer type >> process.c:5404: warning: passing arg 2 of `sys_signal' from incompatib= le pointer type > > This was a misplaced volatile. It's not needed here in the first place= , > so I removed it. Looking closer, the volatile _is_ needed. But it needs to be placed at the right side of the asterisk. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."