From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: replace alloca with strdup Date: Sun, 22 May 2005 01:49:51 +0200 Message-ID: References: <20050521163028.GM28212@boetes.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1116719555 8669 80.91.229.2 (21 May 2005 23:52:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 21 May 2005 23:52:35 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 22 01:52:24 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DZdlR-0006Sz-Hh for ged-emacs-devel@m.gmane.org; Sun, 22 May 2005 01:52:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DZdoZ-00011F-UN for ged-emacs-devel@m.gmane.org; Sat, 21 May 2005 19:55:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DZdoH-0000y2-LO for emacs-devel@gnu.org; Sat, 21 May 2005 19:55:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DZdoD-0000uC-Uu for emacs-devel@gnu.org; Sat, 21 May 2005 19:55:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DZdoB-0000tc-L4 for emacs-devel@gnu.org; Sat, 21 May 2005 19:55:07 -0400 Original-Received: from [195.135.220.2] (helo=mx1.suse.de) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1DZdru-0006Gp-B4 for emacs-devel@gnu.org; Sat, 21 May 2005 19:58:58 -0400 Original-Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id C5EECD895 for ; Sun, 22 May 2005 01:49:52 +0200 (CEST) Original-To: emacs-devel@gnu.org X-Yow: Yow! I just went below the poverty line! In-Reply-To: <20050521163028.GM28212@boetes.org> (Han Boetes's message of "Sat, 21 May 2005 18:30:06 +0200") User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37445 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37445 Han Boetes writes: > Advantages are: > > - simpler code Not really. > - strdup is more portable Not more than alloca. > - error handling Which error? > - you don't have to worry about strdup concerning security The code you changed is already obviously safe. > I hope you like the idea. No. Nobody is reclaiming the storage, so you introduced a memory leak. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."