* Build failure with latest CVS
@ 2006-04-18 9:58 Andreas Schwab
2006-04-18 10:03 ` Juanma Barranquero
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2006-04-18 9:58 UTC (permalink / raw
Cc: emacs-devel
With the latest CVS I'm getting this build failure:
Loading paths.el (source)...
Attempt to autoload tramp-completion-file-name-handler while preparing to dump
make[3]: *** [emacs] Error 255
This is caused by this change:
(tramp-completion-file-name-handler): Add autoload cookie for
adding to `file-name-handler-alist'.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Build failure with latest CVS
2006-04-18 9:58 Build failure with latest CVS Andreas Schwab
@ 2006-04-18 10:03 ` Juanma Barranquero
2006-04-20 5:08 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Juanma Barranquero @ 2006-04-18 10:03 UTC (permalink / raw
Cc: Michael Albinus, emacs-devel
On 4/18/06, Andreas Schwab <schwab@suse.de> wrote:
> With the latest CVS I'm getting this build failure:
While waiting for a fix, I've reverted the autoload part of the
2006-04-17 change on net/tramp.el, so Emacs can be bootstrapped again.
--
/L/e/k/t/u
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Build failure with latest CVS
2006-04-18 10:03 ` Juanma Barranquero
@ 2006-04-20 5:08 ` Michael Albinus
2006-04-20 19:38 ` Richard Stallman
0 siblings, 1 reply; 4+ messages in thread
From: Michael Albinus @ 2006-04-20 5:08 UTC (permalink / raw
Cc: Andreas Schwab, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
"Juanma Barranquero" <lekktu@gmail.com> writes:
> On 4/18/06, Andreas Schwab <schwab@suse.de> wrote:
>
>> With the latest CVS I'm getting this build failure:
>
> While waiting for a fix, I've reverted the autoload part of the
> 2006-04-17 change on net/tramp.el, so Emacs can be bootstrapped again.
I intend to fix it with the following patch. But I don't feel
confident whether it is the right way to do, a review of the patch
would be great. At least it works for me :-)
Best regards, Michael.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch.diff --]
[-- Type: text/x-patch, Size: 1511 bytes --]
Index: lisp/net/tramp.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/net/tramp.el,v
retrieving revision 1.92
diff -u -r1.92 tramp.el
--- lisp/net/tramp.el 18 Apr 2006 10:02:40 -0000 1.92
+++ lisp/net/tramp.el 20 Apr 2006 05:06:59 -0000
@@ -4337,16 +4337,21 @@
(save-match-data (apply (cdr fn) args))
(tramp-completion-run-real-handler operation args))))
+;; Register in file name handler alist.
+;; `tramp-completion-file-name-handler' must not be active when temacs
+;; dumps. And it makes no sense in batch mode anyway.
;;;###autoload
-(put 'tramp-completion-file-name-handler 'safe-magic t)
+(defun tramp-register-file-name-handler ()
+ (unless noninteractive
+ (add-to-list 'file-name-handler-alist
+ (cons tramp-file-name-regexp 'tramp-file-name-handler))
+ (add-to-list 'file-name-handler-alist
+ (cons tramp-completion-file-name-regexp
+ 'tramp-completion-file-name-handler))
+ (put 'tramp-completion-file-name-handler 'safe-magic t)))
-;; Register in file name handler alist
-;;;###autoload
-(add-to-list 'file-name-handler-alist
- (cons tramp-file-name-regexp 'tramp-file-name-handler))
-(add-to-list 'file-name-handler-alist
- (cons tramp-completion-file-name-regexp
- 'tramp-completion-file-name-handler))
+;;;###autoload (add-hook 'emacs-startup-hook 'tramp-register-file-name-handler)
+(tramp-register-file-name-handler)
;;;###autoload
(defun tramp-unload-file-name-handler-alist ()
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Build failure with latest CVS
2006-04-20 5:08 ` Michael Albinus
@ 2006-04-20 19:38 ` Richard Stallman
0 siblings, 0 replies; 4+ messages in thread
From: Richard Stallman @ 2006-04-20 19:38 UTC (permalink / raw
Cc: lekktu, emacs-devel, schwab
+;; Register in file name handler alist.
+;; `tramp-completion-file-name-handler' must not be active when temacs
+;; dumps. And it makes no sense in batch mode anyway.
;;;###autoload
The basic idea seems correct to me.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-04-20 19:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-18 9:58 Build failure with latest CVS Andreas Schwab
2006-04-18 10:03 ` Juanma Barranquero
2006-04-20 5:08 ` Michael Albinus
2006-04-20 19:38 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).