unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* minibuffer-local-isearch-map
@ 2006-06-28  7:41 Andreas Roehler
  2006-06-28 14:48 ` minibuffer-local-isearch-map Juri Linkov
  2006-06-29 12:59 ` minibuffer-local-isearch-map Richard Stallman
  0 siblings, 2 replies; 6+ messages in thread
From: Andreas Roehler @ 2006-06-28  7:41 UTC (permalink / raw
  Cc: Daniel LaLiberte

convenience

What about to have analog with

;;      bindings.el
;; ...
;;     (define-key map [down]  'next-history-element)
;;     (define-key map [up]    'previous-history-element)       

the already in isearch.el keyed commands

    (define-key map "\M-n" 'isearch-ring-advance)
    (define-key map "\M-p" 'isearch-ring-retreat)

also assigned as

    (define-key map [up]    'isearch-ring-advance)          
    (define-key map [down]  'isearch-ring-retreat)

At least it works here.

(At GNU Emacs 22.0.50.2 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll 
bars) of 2006-06-18.)

__
Andreas Roehler

diff -c isearch.el ~/emacs/veraendert/isearch.el
*** isearch.el    2006-05-06 01:37:31.000000000 +
~/emacs/veraendert/isearch.el    2006-06-28 09:32:19.000000000 +0200
***************
*** 377,382 ****
--- 377,386 ----
 
      (define-key map "\M-n" 'isearch-ring-advance)
      (define-key map "\M-p" 'isearch-ring-retreat)
+     ;; 2006-06-28 a.roehler@web.de changed section start
+     (define-key map [up]    'isearch-ring-advance)
+     (define-key map [down]  'isearch-ring-retreat)
+     ;; 2006-06-28 a.roehler@web.de changed section end
      (define-key map "\M-y" 'isearch-yank-kill)
 
      (define-key map "\M-\t" 'isearch-complete)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: minibuffer-local-isearch-map
  2006-06-28  7:41 minibuffer-local-isearch-map Andreas Roehler
@ 2006-06-28 14:48 ` Juri Linkov
  2006-06-29 12:21   ` minibuffer-local-isearch-map Mathias Dahl
  2006-06-29 12:59 ` minibuffer-local-isearch-map Richard Stallman
  1 sibling, 1 reply; 6+ messages in thread
From: Juri Linkov @ 2006-06-28 14:48 UTC (permalink / raw
  Cc: liberte, emacs-devel

> convenience
>
> What about to have analog with
>
> ;;      bindings.el
> ;; ...
> ;;     (define-key map [down]  'next-history-element)
> ;;     (define-key map [up]    'previous-history-element)
>
> the already in isearch.el keyed commands
>
>    (define-key map "\M-n" 'isearch-ring-advance)
>    (define-key map "\M-p" 'isearch-ring-retreat)
>
> also assigned as
>
>    (define-key map [up]    'isearch-ring-advance)           (define-key
> map [down]  'isearch-ring-retreat)

[up] and [down] are convenient key to exit isearch mode,
just like C-n and C-p can exit isearch mode now.

-- 
Juri Linkov
http://www.jurta.org/emacs/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: minibuffer-local-isearch-map
  2006-06-28 14:48 ` minibuffer-local-isearch-map Juri Linkov
@ 2006-06-29 12:21   ` Mathias Dahl
  2006-06-29 12:42     ` minibuffer-local-isearch-map Andreas Schwab
  2006-06-30 11:06     ` minibuffer-local-isearch-map Richard Stallman
  0 siblings, 2 replies; 6+ messages in thread
From: Mathias Dahl @ 2006-06-29 12:21 UTC (permalink / raw
  Cc: liberte, Andreas Roehler, emacs-devel

> [up] and [down] are convenient key to exit isearch mode,
> just like C-n and C-p can exit isearch mode now.

Sorry for jumping in in this thread this late, but why do we need so
many ways to end isearch-mode? I use C-g myself even though I try to
teach myself to use RET instead, which seems to be "nicer".

If [up] and [down] can be bound to more useful things, why not do that?

Again, I did not follow this discussion so if you think it seems I
don't know what I am talking about, please just ignore me... :)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: minibuffer-local-isearch-map
  2006-06-29 12:21   ` minibuffer-local-isearch-map Mathias Dahl
@ 2006-06-29 12:42     ` Andreas Schwab
  2006-06-30 11:06     ` minibuffer-local-isearch-map Richard Stallman
  1 sibling, 0 replies; 6+ messages in thread
From: Andreas Schwab @ 2006-06-29 12:42 UTC (permalink / raw
  Cc: Juri Linkov, liberte, Andreas Roehler, emacs-devel

"Mathias Dahl" <mathias.dahl@gmail.com> writes:

> If [up] and [down] can be bound to more useful things, why not do that?

[up] and [down] should always do the same as C-p and C-n, resp.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: minibuffer-local-isearch-map
  2006-06-28  7:41 minibuffer-local-isearch-map Andreas Roehler
  2006-06-28 14:48 ` minibuffer-local-isearch-map Juri Linkov
@ 2006-06-29 12:59 ` Richard Stallman
  1 sibling, 0 replies; 6+ messages in thread
From: Richard Stallman @ 2006-06-29 12:59 UTC (permalink / raw
  Cc: liberte, emacs-devel

The arrow keys ought to exit from search.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: minibuffer-local-isearch-map
  2006-06-29 12:21   ` minibuffer-local-isearch-map Mathias Dahl
  2006-06-29 12:42     ` minibuffer-local-isearch-map Andreas Schwab
@ 2006-06-30 11:06     ` Richard Stallman
  1 sibling, 0 replies; 6+ messages in thread
From: Richard Stallman @ 2006-06-30 11:06 UTC (permalink / raw
  Cc: juri, liberte, andreas.roehler, emacs-devel

    Sorry for jumping in in this thread this late, but why do we need so
    many ways to end isearch-mode? 

Because it is convenient.

I will not change this, so please let's not spend time arguing about it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2006-06-30 11:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-28  7:41 minibuffer-local-isearch-map Andreas Roehler
2006-06-28 14:48 ` minibuffer-local-isearch-map Juri Linkov
2006-06-29 12:21   ` minibuffer-local-isearch-map Mathias Dahl
2006-06-29 12:42     ` minibuffer-local-isearch-map Andreas Schwab
2006-06-30 11:06     ` minibuffer-local-isearch-map Richard Stallman
2006-06-29 12:59 ` minibuffer-local-isearch-map Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).