From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: Problem report #13 FALSE Date: Thu, 11 May 2006 11:30:34 +0200 Message-ID: References: <200604111549.k3BFnQ2N015126@scanner2.ics.uci.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1147339872 5311 80.91.229.2 (11 May 2006 09:31:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 11 May 2006 09:31:12 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 11 11:31:10 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fe7Vb-0000Yh-LB for ged-emacs-devel@m.gmane.org; Thu, 11 May 2006 11:31:00 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fe7Vb-00035r-3v for ged-emacs-devel@m.gmane.org; Thu, 11 May 2006 05:30:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fe7VO-00035M-0A for emacs-devel@gnu.org; Thu, 11 May 2006 05:30:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fe7VL-00034G-UE for emacs-devel@gnu.org; Thu, 11 May 2006 05:30:44 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fe7VL-00033w-Ot for emacs-devel@gnu.org; Thu, 11 May 2006 05:30:43 -0400 Original-Received: from [195.135.220.2] (helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Fe7Wo-0001cO-Sm for emacs-devel@gnu.org; Thu, 11 May 2006 05:32:15 -0400 Original-Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 9AAE0EF36; Thu, 11 May 2006 11:30:41 +0200 (CEST) Original-To: Kenichi Handa X-Yow: Let's send the Russians defective lifestyle accessories! In-Reply-To: (Kenichi Handa's message of "Thu, 11 May 2006 11:19:00 +0900") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:54250 Archived-At: Kenichi Handa writes: > Dan Nicolaescu writes: > >> CID: 13 >> Checker: FORWARD_NULL (help) >> File: emacs/src/coding.c >> Function: encode_coding_string >> Description: Variable "(coding)->cmp_data" tracked as NULL was passed = to a function that dereferences it. > > I see no bug here. A member of (coding)->cmp_data is > accessed only after checking (coding)->cmp_data is not NULL. > >> Event var_compare_op: Added "(coding)->cmp_data" due to comparison "(c= oding)->cmp_data =3D=3D 0" >> Also see events: [var_deref_model] >> At conditional (1): "(coding)->cmp_data =3D=3D 0" taking true path > >> 6435 if (coding->type !=3D coding_type_ccl >> 6436 && (! coding->cmp_data || coding->cmp_data->used =3D=3D 0)= ) >> 6437 { > > Does the checker require it to be writen as below? > >> 6436 && (coding->cmp_data ? coding->cmp_data->used =3D=3D 0 : 1= )) That would be stupid, since it would be a major obfucation. But that's not the point of the report, the derefence is supposed to happen in encode_coding. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."