From: Andreas Schwab <schwab@suse.de>
Cc: emacs-devel@gnu.org
Subject: Re: Problem report #13 FALSE
Date: Thu, 11 May 2006 11:30:34 +0200 [thread overview]
Message-ID: <jer730zz5x.fsf@sykes.suse.de> (raw)
In-Reply-To: <E1Fe0lY-0002QP-00@etlken> (Kenichi Handa's message of "Thu, 11 May 2006 11:19:00 +0900")
Kenichi Handa <handa@m17n.org> writes:
> Dan Nicolaescu <dann@ics.uci.edu> writes:
>
>> CID: 13
>> Checker: FORWARD_NULL (help)
>> File: emacs/src/coding.c
>> Function: encode_coding_string
>> Description: Variable "(coding)->cmp_data" tracked as NULL was passed to a function that dereferences it.
>
> I see no bug here. A member of (coding)->cmp_data is
> accessed only after checking (coding)->cmp_data is not NULL.
>
>> Event var_compare_op: Added "(coding)->cmp_data" due to comparison "(coding)->cmp_data == 0"
>> Also see events: [var_deref_model]
>> At conditional (1): "(coding)->cmp_data == 0" taking true path
>
>> 6435 if (coding->type != coding_type_ccl
>> 6436 && (! coding->cmp_data || coding->cmp_data->used == 0))
>> 6437 {
>
> Does the checker require it to be writen as below?
>
>> 6436 && (coding->cmp_data ? coding->cmp_data->used == 0 : 1))
That would be stupid, since it would be a major obfucation. But that's
not the point of the report, the derefence is supposed to happen in
encode_coding.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-05-11 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 15:49 Problem report #13 Dan Nicolaescu
2006-05-11 2:19 ` Problem report #13 FALSE Kenichi Handa
2006-05-11 2:46 ` Dan Nicolaescu
2006-05-11 9:30 ` Andreas Schwab [this message]
2006-05-11 10:58 ` Kenichi Handa
2006-05-11 9:40 ` Jason Rumney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jer730zz5x.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).