Re: Mule-UCS 0.84 (KOUGETSUDAI) release.

[Andreas Schwab <schwab@suse.de>]

Kenichi Handa <handa@m17n.org> writes:

|> In article <je7keo7ned.fsf@sykes.suse.de>, Andreas Schwab <schwab@suse.de> writes:
|> > IMHO this patch is better:
|> 
|> > --- mucs.el	2002/12/05 10:43:28	1.1
|> > +++ mucs.el	2002/12/05 10:46:26
|> > @@ -196,7 +196,7 @@ In order to embed data or lisp code, use
|> >  		    (funcall (car hookval))
|> >  		    result)
|> >  	    hookval (cdr hookval)))
|> > -    (cons 'progn
|> > +    (list 'progn
|> >  	  result)))
|>  
|> >  (defmacro mucs-define-package (package &rest form)
|> 
|> Could you explain why?

Actually this is also wrong.  The right fix is to collect the function
results with cons instead of append.  Each hook function is returning a
form to be evaluated, and the final form returned by the macro is
supposed to be one that evaluates each form in sequence.

--- mucs.el	2002/12/05 10:43:28	1.1
+++ mucs.el	2002/12/05 12:15:29
@@ -192,7 +192,7 @@ In order to embed data or lisp code, use
       (if (not (listp hookval))
 	  (error "Invalid hook:%S" hooksym)))
     (while hookval
-      (setq result (append
+      (setq result (cons
 		    (funcall (car hookval))
 		    result)
 	    hookval (cdr hookval)))

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."