From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: GCC warning in minibuf.c Date: Thu, 20 Oct 2005 15:07:47 +0200 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1129816811 20917 80.91.229.2 (20 Oct 2005 14:00:11 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 20 Oct 2005 14:00:11 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 20 16:00:09 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ESauN-0004LK-Ek for ged-emacs-devel@m.gmane.org; Thu, 20 Oct 2005 15:56:39 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ESauM-0005sv-Ok for ged-emacs-devel@m.gmane.org; Thu, 20 Oct 2005 09:56:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ESa9L-0002XW-4W for emacs-devel@gnu.org; Thu, 20 Oct 2005 09:08:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ESa9J-0002TQ-3Q for emacs-devel@gnu.org; Thu, 20 Oct 2005 09:08:02 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ESa9I-0002Sl-8N for emacs-devel@gnu.org; Thu, 20 Oct 2005 09:08:00 -0400 Original-Received: from [195.135.220.2] (helo=mx1.suse.de) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1ESa98-00031x-N4; Thu, 20 Oct 2005 09:07:50 -0400 Original-Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 10256EDF1; Thu, 20 Oct 2005 15:07:49 +0200 (CEST) Original-To: Eli Zaretskii X-Yow: On SECOND thought, maybe I'll heat up some BAKED BEANS and watch REGIS PHILBIN.. It's GREAT to be ALIVE!! In-Reply-To: (Eli Zaretskii's message of "Thu, 20 Oct 2005 14:32:37 +0200") User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:44416 Archived-At: Eli Zaretskii writes: > Here, the 2nd argument `function' is declared to accept a single > Lisp_Object argument. However, minibuf.c calls > internal_with_output_to_temp_buffer as follows: > > internal_with_output_to_temp_buffer ("*Completions*", > Fdisplay_completion_list, > Fsort (completions, Qstring_lessp)); > > and Fdisplay_completion_list is declared to accept 2 Lisp_Object > arguments. Then Fdisplay_completion_list is definitely the wrong function to pass to internal_with_output_to_temp_buffer. > I think this is a bogus warning, I don't agree. Fdisplay_completion_list will be called with only a singl= e parameter and will receive garbage in the second one. A sure way to make Emacs crash. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."