From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: hash-table-{to, from}-alist Date: Tue, 02 Dec 2008 22:27:37 +0100 Message-ID: References: <863aknitfg.fsf@lifelogs.com> <86bpwe9su5.fsf@lifelogs.com> <867i6z1jo5.fsf_-_@lifelogs.com> <86ej14vhvg.fsf@lifelogs.com> <20081122054510.GA28298@tomas> <873ahkkkt5.fsf@xemacs.org> <20081122152126.GA4142@tomas> <87vdufk6do.fsf@xemacs.org> <867i6tt4yz.fsf@lifelogs.com> <87bpw4k1z6.fsf@xemacs.org> <86bpw3d829.fsf@lifelogs.com> <87k5ari5jh.fsf@xemacs.org> <86prkiiia2.fsf@lifelogs.com> <86ej0ygr5j.fsf@lifelogs.com> <861vwygpc6.fsf@lifelogs.com> <868wqzd06x.fsf@lifelogs.com> <86r64q70v3.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1228253279 24041 80.91.229.12 (2 Dec 2008 21:27:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 2 Dec 2008 21:27:59 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 02 22:29:02 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L7cnm-0002dz-0H for ged-emacs-devel@m.gmane.org; Tue, 02 Dec 2008 22:29:02 +0100 Original-Received: from localhost ([127.0.0.1]:48757 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7cmb-0007Vq-O2 for ged-emacs-devel@m.gmane.org; Tue, 02 Dec 2008 16:27:49 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L7cmX-0007Vk-NU for emacs-devel@gnu.org; Tue, 02 Dec 2008 16:27:45 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L7cmV-0007VY-Bd for emacs-devel@gnu.org; Tue, 02 Dec 2008 16:27:44 -0500 Original-Received: from [199.232.76.173] (port=54557 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7cmV-0007VV-5M for emacs-devel@gnu.org; Tue, 02 Dec 2008 16:27:43 -0500 Original-Received: from ns.suse.de ([195.135.220.2]:41286 helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L7cmU-0004q2-SK for emacs-devel@gnu.org; Tue, 02 Dec 2008 16:27:43 -0500 Original-Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 5C01C4296A; Tue, 2 Dec 2008 22:27:38 +0100 (CET) X-Yow: America!! I saw it all!! Vomiting! Waving! JERRY FALWELLING into your void tube of UHF oblivion!! SAFEWAY of the mind -- In-Reply-To: <86r64q70v3.fsf@lifelogs.com> (Ted Zlatanov's message of "Tue, 02 Dec 2008 14:56:00 -0600") User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.3 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106438 Archived-At: Ted Zlatanov writes: > I ended up with this code to put a list into Fmake_hash_table format > ('params' is a Lisp_Object that holds a bunch of conses). > > int param_count =3D 0; > Lisp_Object *pa =3D (Lisp_Object*) xmalloc(XFASTINT(Flength(para= ms)) * sizeof(Lisp_Object)); > > while (!NILP(params)) > { > pa[param_count++] =3D CAR_SAFE(params); > params =3D CDR_SAFE(params); > } > > Lisp_Object ht =3D Fmake_hash_table(param_count, pa); This is of course a memory leak, since pa is never freed. > I would prefer it if I could avoid all that work, but it seems (from > reading lisp.h and hunting for similar code) that it must be done as > above. I don't see a macro to convert a Lisp_Object that holds a list > into the Lisp_Object* that a lot of functions need. Since you know the max size of the array, just declare it as such. (One more reason to implement it in Lisp.) Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."