From: Andreas Schwab <schwab@suse.de>
To: "Juanma Barranquero" <lekktu@gmail.com>
Cc: Emacs-Devel <emacs-devel@gnu.org>
Subject: Re: Error checking in format-network-address
Date: Tue, 27 Mar 2007 18:15:39 +0200 [thread overview]
Message-ID: <jelkhi8xxw.fsf@sykes.suse.de> (raw)
In-Reply-To: <f7ccd24b0703270904r89c9c15j1046be89acd21cf8@mail.gmail.com> (Juanma Barranquero's message of "Tue, 27 Mar 2007 18:04:21 +0200")
"Juanma Barranquero" <lekktu@gmail.com> writes:
> Index: src/process.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/process.c,v
> retrieving revision 1.508
> diff -u -2 -r1.508 process.c
> --- src/process.c 27 Mar 2007 15:19:33 -0000 1.508
> +++ src/process.c 27 Mar 2007 15:38:12 -0000
> @@ -1296,5 +1296,18 @@
>
> for (i = 0; i < nargs; i++)
> - args[i+1] = p->contents[i];
> + {
> + int element = XINT (p->contents[i]);
Better use EMACS_INT here.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2007-03-27 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 16:04 Error checking in format-network-address Juanma Barranquero
2007-03-27 16:15 ` Andreas Schwab [this message]
2007-03-27 19:41 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jelkhi8xxw.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).