From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: unicode build: "comparison is always true" warnings Date: Sat, 24 Nov 2007 14:57:42 +0100 Message-ID: References: <87oddltv7f.fsf@everybody.org> <87hcjcoo2x.fsf@everybody.org> <87wss8mypv.fsf@everybody.org> <87sl2wmmyk.fsf@everybody.org> <4747EF20.7050604@swipnet.se> <4747FDF6.3050203@swipnet.se> <4748064D.6010405@swipnet.se> <4748224C.6030602@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1195912837 15752 80.91.229.12 (24 Nov 2007 14:00:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 24 Nov 2007 14:00:37 +0000 (UTC) Cc: Emacs-Devel To: Jan =?iso-8859-1?Q?Dj=E4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 24 15:00:43 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IvvWJ-0000ZD-2m for ged-emacs-devel@m.gmane.org; Sat, 24 Nov 2007 14:58:07 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IvvW4-0002bU-Cm for ged-emacs-devel@m.gmane.org; Sat, 24 Nov 2007 08:57:52 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IvvW0-0002Zu-U0 for emacs-devel@gnu.org; Sat, 24 Nov 2007 08:57:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IvvVy-0002Vk-Av for emacs-devel@gnu.org; Sat, 24 Nov 2007 08:57:47 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IvvVy-0002Vc-7V for emacs-devel@gnu.org; Sat, 24 Nov 2007 08:57:46 -0500 Original-Received: from ns.suse.de ([195.135.220.2] helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IvvVx-0008LL-K1 for emacs-devel@gnu.org; Sat, 24 Nov 2007 08:57:45 -0500 Original-Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id D7BCF20FDC; Sat, 24 Nov 2007 14:57:42 +0100 (CET) X-Yow: .. I want to perform cranial activities with Tuesday Weld!! In-Reply-To: <4748224C.6030602@swipnet.se> ("Jan =?iso-8859-1?Q?Dj=E4rv=22?= =?iso-8859-1?Q?'s?= message of "Sat\, 24 Nov 2007 14\:08\:28 +0100") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84049 Archived-At: Jan Dj=E4rv writes: > The patch just needs some small changes: > > > *** movemail.c.~1.88.~ 2007-07-27 09:52:07.000000000 +0200 > --- movemail.c 2007-11-24 14:07:13.000000000 +0100 > *************** > *** 324,338 **** > --- 324,345 ---- > while (p !=3D tempname && !IS_DIRECTORY_SEP (p[-1])) > p--; > *p =3D 0; > + #ifndef HAVE_MKSTEMP > strcpy (p, "EXXXXXX"); > mktemp (tempname); > unlink (tempname); > + #endif > > while (1) > { > /* Create the lock file, but not under the lock file name. *= / > /* Give up if cannot do that. */ > + #ifndef HAVE_MKSTEMP > desc =3D open (tempname, O_WRONLY | O_CREAT | O_EXCL, 0666); > + #else > + strcpy (p, "EXXXXXX"); > + desc =3D mkstemp (tempname); > + #endif > if (desc < 0) > { > char *message =3D (char *) xmalloc (strlen (tempname) + 5= 0); I'd suggest moving the mktemp into the loop as well. This will avoid code duplication. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."