Re: Fwd: parse-time-string error with non ASCII timestamp

[Andreas Schwab <schwab@suse.de>]

Kenichi Handa <handa@m17n.org> writes:

> In article <9649271a0704170310s5c92163bv15f8d6e8eaef37db@mail.gmail.com>, "Levin Du" <zslevin@gmail.com> writes:
> [...]
>>    My timestamp includes Chinese number, when the following executes:
>
>>     (parse-time-string "<2007-04-02 一>")  ; the 12nd char is the
>> Chinese number.
>
>> An error will occur:
>
>> Debugger entered--Lisp error: (args-out-of-range [nil nil nil nil nil
>> nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil
> [...]
>> This is a patch I wrote to solve this problem:
>> *** /home/zslevin/Cook/emacs/lisp/calendar/parse-time.el.orig
>> 2007-04-02 10:01:27.000000000 +0800
>> --- /home/zslevin/Cook/emacs/lisp/calendar/parse-time.el        2007-04-02
>> 15:35:07.000000000 +0800
>> ***************
>> *** 66,72 ****
>>     (aref parse-time-digits char))
>
>>   (defsubst parse-time-string-chars (char)
>> !   (aref parse-time-syntax char))
>
>>   (put 'parse-error 'error-conditions '(parse-error error))
>>   (put 'parse-error 'error-message "Parsing error")
>> --- 66,73 ----
>>     (aref parse-time-digits char))
>
>>   (defsubst parse-time-string-chars (char)
>> !   (and (< char (length parse-time-syntax))
>> !        (aref parse-time-syntax char)))
>
> It seems that this is the right fix at the moment because
> parse-time.el doesn't pay attention to non-ASCII characters
> at all.   In the future, we may have to improve it for
> non-ASCII characters if necesary.

I'd guess all that needs to be done is to make parse-time-digits and
parse-time-syntax char tables.

> Shall I install that change?

digit-char-p has the same problem.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."