unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Display (null) unavailable, simulating -nw
@ 2006-03-20 20:04 Andreas Schwab
  2006-03-20 20:35 ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2006-03-20 20:04 UTC (permalink / raw)
  Cc: emacs-devel

Emacs now always complains that "Display (null)" is unavailable when
DISPLAY is unset.  Eli, I don't think that your change works as intended.
Note that when display_arg != 1 (ie. == 0) then displayname is always
null.  Trying to print NULL as a string can also cause a crash.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Display (null) unavailable, simulating -nw
  2006-03-20 20:04 Display (null) unavailable, simulating -nw Andreas Schwab
@ 2006-03-20 20:35 ` Eli Zaretskii
  2006-03-20 20:41   ` Andreas Schwab
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2006-03-20 20:35 UTC (permalink / raw)
  Cc: emacs-devel

> From: Andreas Schwab <schwab@suse.de>
> Cc: emacs-devel@gnu.org
> Date: Mon, 20 Mar 2006 21:04:02 +0100
> 
> Emacs now always complains that "Display (null)" is unavailable when
> DISPLAY is unset.  Eli, I don't think that your change works as intended.

It's not my change, as you can see in the ChangeLog.  I just installed
it, at Richard's request.

> Note that when display_arg != 1 (ie. == 0) then displayname is always
> null.  Trying to print NULL as a string can also cause a crash.

I think I fixed this, but I cannot verify positively, since I cannot
currently build on X.  Please test.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Display (null) unavailable, simulating -nw
  2006-03-20 20:35 ` Eli Zaretskii
@ 2006-03-20 20:41   ` Andreas Schwab
  2006-03-20 20:43     ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2006-03-20 20:41 UTC (permalink / raw)
  Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> I think I fixed this, but I cannot verify positively, since I cannot
> currently build on X.  Please test.

I think this is now backwards from what the original submitter intended.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Display (null) unavailable, simulating -nw
  2006-03-20 20:41   ` Andreas Schwab
@ 2006-03-20 20:43     ` Eli Zaretskii
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2006-03-20 20:43 UTC (permalink / raw)
  Cc: emacs-devel

> From: Andreas Schwab <schwab@suse.de>
> Date: Mon, 20 Mar 2006 21:41:31 +0100
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I think I fixed this, but I cannot verify positively, since I cannot
> > currently build on X.  Please test.
> 
> I think this is now backwards from what the original submitter intended.

In that case, please feel free to fix as you see fit.  Sorry for being
too dumb to understand.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-03-20 20:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-20 20:04 Display (null) unavailable, simulating -nw Andreas Schwab
2006-03-20 20:35 ` Eli Zaretskii
2006-03-20 20:41   ` Andreas Schwab
2006-03-20 20:43     ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).