From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: $USERPROFILE for $HOME on W32 Date: Thu, 25 Nov 2004 18:49:56 +0100 Message-ID: References: <87vfbycsgj.fsf-monnier+emacs@gnu.org> <87mzx69bkn.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1101410276 8814 80.91.229.6 (25 Nov 2004 19:17:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 25 Nov 2004 19:17:56 +0000 (UTC) Cc: emacs-devel@gnu.org, Jason Rumney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 25 20:17:48 2004 Return-path: Original-Received: from mail-relay.eunet.no ([193.71.71.242]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CXOu5-0006sk-00 for ; Thu, 25 Nov 2004 20:03:41 +0100 Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by mail-relay.eunet.no (8.13.1/8.13.1/GN) with ESMTP id iAPHrq3n007465 for ; Thu, 25 Nov 2004 18:53:52 +0100 (CET) (envelope-from emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org) Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CXNug-0004Wl-GT for ged-emacs-devel@m.gmane.org; Thu, 25 Nov 2004 13:00:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CXNuG-0004Wg-64 for emacs-devel@gnu.org; Thu, 25 Nov 2004 12:59:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CXNuF-0004WU-QC for emacs-devel@gnu.org; Thu, 25 Nov 2004 12:59:47 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CXNuF-0004WR-NP for emacs-devel@gnu.org; Thu, 25 Nov 2004 12:59:47 -0500 Original-Received: from [195.135.220.2] (helo=Cantor.suse.de) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1CXNkk-0002xb-Ga; Thu, 25 Nov 2004 12:49:58 -0500 Original-Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id 75590116E00E; Thu, 25 Nov 2004 18:49:57 +0100 (CET) Original-To: Stefan X-Yow: Let's climb to the TOP of that MOUNTAIN and think about STRIP MINING!! In-Reply-To: (Stefan's message of "Thu, 25 Nov 2004 12:45:48 -0500") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30357 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30357 Stefan writes: >>> + /* Set dir and shell from environment variables. */ >>> + strcpy (the_passwd.pw_dir, getenv ("HOME")); > >> What if strlen (getenv ("HOME")) >=3D sizeof (the_passwd.pw_dir)? > > Well, tough! > This code is not new: it's just moved from one place to another so it's= not > a new problem. I know, but it is still worth to be fixed. I don't see why it can't be dynamically allocated in the first place. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."