From: Andreas Schwab <schwab@suse.de>
Cc: emacs-devel@gnu.org
Subject: Re: request for review: Doing direct file I/O in Emacs Lisp
Date: Mon, 10 May 2004 11:38:09 +0200 [thread overview]
Message-ID: <jebrkw7hby.fsf@sykes.suse.de> (raw)
In-Reply-To: <m2d65cx1ow.fsf@Majnun.local> (John Wiegley's message of "Sun, 09 May 2004 22:59:11 -0700")
John Wiegley <johnw@gnu.org> writes:
> +DEFUN ("file-handle-open", Ffile_handle_open, Sfile_handle_open,
> + 2, 2, 0,
> + doc: /* Open a file handle for direct reading/writing. */)
> + (path, mode)
> + Lisp_Object path, mode;
> +{
> + FILE *stream;
> + Lisp_Object handle, lispstream;
> + struct Lisp_File_Handle *lh;
> +
> + if (! STRINGP (path) || ! STRINGP (mode))
> + return Qnil;
> +
> + if (! Ffile_exists_p (path))
> + return Qnil;
> +
> + stream = fopen(SDATA (path), SDATA (mode));
> + if (! stream)
> + return Qnil;
You should signal an error instead of just returning nil.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2004-05-10 9:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-10 5:59 request for review: Doing direct file I/O in Emacs Lisp John Wiegley
2004-05-10 6:52 ` Kim F. Storm
2004-05-10 8:27 ` David Kastrup
2004-05-10 14:21 ` Stefan Monnier
2004-05-10 15:59 ` David Kastrup
2004-05-10 16:36 ` Stefan Monnier
2004-05-10 17:00 ` David Kastrup
2004-05-10 17:22 ` Stefan Monnier
2004-05-11 9:23 ` John Wiegley
2004-05-11 10:22 ` David Kastrup
2004-05-10 9:38 ` Andreas Schwab [this message]
2004-05-10 11:29 ` Eli Zaretskii
2004-05-10 11:23 ` Andreas Schwab
2004-05-10 15:04 ` Eli Zaretskii
2004-05-10 14:19 ` Stefan Monnier
2004-05-10 17:46 ` Oliver Scholz
2004-05-10 18:21 ` Stefan Monnier
2004-05-10 22:40 ` Oliver Scholz
2004-05-11 12:22 ` Richard Stallman
2004-05-10 17:54 ` Richard Stallman
2004-05-11 9:20 ` John Wiegley
2004-05-12 19:41 ` Richard Stallman
2004-05-13 7:59 ` Kai Grossjohann
2004-05-14 9:21 ` Richard Stallman
2004-05-14 10:42 ` Kai Grossjohann
2004-05-15 8:53 ` Richard Stallman
2004-05-15 16:27 ` Kai Grossjohann
2004-05-16 13:20 ` Richard Stallman
2004-05-14 21:43 ` John Wiegley
2004-05-15 18:33 ` Richard Stallman
2004-05-15 21:36 ` John Wiegley
2004-05-15 22:13 ` David Kastrup
2004-05-16 6:41 ` Eli Zaretskii
2004-05-16 17:46 ` David Kastrup
2004-05-17 11:04 ` Richard Stallman
2004-05-13 22:50 ` John Wiegley
2004-05-14 21:02 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jebrkw7hby.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).