Re: easy-menu subtlety

[Andreas Schwab <schwab@suse.de>]

Dan Nicolaescu <dann@ics.uci.edu> writes:

> The last 3 lines of this code sequence in lisp/progmodes/verilog-mode.el:
>
>     ("Move"
>      ,(if (featurep 'xemacs)
>           (progn 
>             ["Beginning of function"            verilog-beg-of-defun t]
>             ["End of function"                  verilog-end-of-defun t]
>             ["Mark function"                    verilog-mark-defun t])
>         ["Beginning of function"                beginning-of-defun t]
>         ["End of function"                      end-of-defun t]
>         ["Mark function"                        mark-defun t])

That looks completely bogus to me.  The result of the evaluation of the
form is a single vector, with the other two just thrown away.  I think
the intention was to write this:

    ("Move"
     ,@(if (featurep 'xemacs)
	   '(["Beginning of function"		verilog-beg-of-defun t]
	     ["End of function"			verilog-end-of-defun t]
	     ["Mark function"			verilog-mark-defun t])
	'(["Beginning of function"		beginning-of-defun t]
	  ["End of function"			end-of-defun t]
	  ["Mark function"			mark-defun t]))

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."