From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: with-temp-buffer and undo [was: Big desktop undo buffer crashes Emacs] Date: Fri, 12 May 2006 13:41:02 +0200 Message-ID: References: <24090.1146238861@olgas.newt.com> <87slngh3wu.fsf@olgas.newt.com> <200605120450.k4C4ovkM019797@jane.dms.auburn.edu> <44643259.3050302@soem.dk> <4464686F.7050101@soem.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1147434170 25142 80.91.229.2 (12 May 2006 11:42:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 12 May 2006 11:42:50 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, wohler@newt.com, Luc Teirlinck , rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 12 13:42:45 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FeW2b-0007Ho-Qp for ged-emacs-devel@m.gmane.org; Fri, 12 May 2006 13:42:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FeW2b-0001Se-G7 for ged-emacs-devel@m.gmane.org; Fri, 12 May 2006 07:42:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FeW1L-0000DJ-UI for emacs-devel@gnu.org; Fri, 12 May 2006 07:41:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FeW1G-0000A5-Q7 for emacs-devel@gnu.org; Fri, 12 May 2006 07:41:22 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FeW1G-00009z-LR; Fri, 12 May 2006 07:41:18 -0400 Original-Received: from [195.135.220.15] (helo=mx2.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FeW2x-0002qw-2i; Fri, 12 May 2006 07:43:03 -0400 Original-Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 149E21EB9A; Fri, 12 May 2006 13:41:08 +0200 (CEST) Original-To: Lars Hansen X-Yow: The PILLSBURY DOUGHBOY is CRYING for an END to BURT REYNOLDS movies!! In-Reply-To: <4464686F.7050101@soem.dk> (Lars Hansen's message of "Fri, 12 May 2006 12:50:23 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:54321 gmane.emacs.pretest.bugs:12005 Archived-At: Lars Hansen writes: > Lars Hansen wrote: > >>I suggest to use with-temp-buffer (and buffer-disable-undo) >> =20 >> > Does it ever make sense to save undo information in a temporary buffer? > If not, I suggest to disable it in with-temp-buffer. > Patch attached. > *** subr.el~ 2006-05-12 08:24:10.000000000 +0200 > --- subr.el 2006-05-12 12:40:59.575290323 +0200 > *************** > *** 2220,2226 **** > See also `with-temp-file' and `with-output-to-string'." > (declare (indent 0) (debug t)) > (let ((temp-buffer (make-symbol "temp-buffer"))) > ! `(let ((,temp-buffer (generate-new-buffer " *temp*"))) > (unwind-protect > (with-current-buffer ,temp-buffer > ,@body) > --- 2220,2227 ---- > See also `with-temp-file' and `with-output-to-string'." > (declare (indent 0) (debug t)) > (let ((temp-buffer (make-symbol "temp-buffer"))) > ! `(let ((,temp-buffer (generate-new-buffer " *temp*")) > ! (buffer-undo-list t)) > (unwind-protect > (with-current-buffer ,temp-buffer > ,@body) This won't disable undo in the temp buffer, you'd need to move that below with-current-buffer. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."