From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: unicode build: "comparison is always true" warnings Date: Fri, 23 Nov 2007 19:54:51 +0100 Message-ID: References: <87oddltv7f.fsf@everybody.org> <87hcjcoo2x.fsf@everybody.org> <87abp4olb5.fsf@everybody.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1195844109 21413 80.91.229.12 (23 Nov 2007 18:55:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Nov 2007 18:55:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: mah@everybody.org (Mark A. Hershberger) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 23 19:55:16 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IvdgH-00079X-OY for ged-emacs-devel@m.gmane.org; Fri, 23 Nov 2007 19:55:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ivdg3-0002p7-B0 for ged-emacs-devel@m.gmane.org; Fri, 23 Nov 2007 13:54:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ivdg0-0002p2-3B for emacs-devel@gnu.org; Fri, 23 Nov 2007 13:54:56 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ivdfx-0002oW-Ru for emacs-devel@gnu.org; Fri, 23 Nov 2007 13:54:54 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ivdfx-0002oT-Op for emacs-devel@gnu.org; Fri, 23 Nov 2007 13:54:53 -0500 Original-Received: from ns2.suse.de ([195.135.220.15] helo=mx2.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ivdfx-0004Lf-4w for emacs-devel@gnu.org; Fri, 23 Nov 2007 13:54:53 -0500 Original-Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id CF7522BF05; Fri, 23 Nov 2007 19:54:51 +0100 (CET) X-Yow: .. I want FORTY-TWO TRYNEL FLOATATION SYSTEMS installed within SIX AND A HALF HOURS!!! In-Reply-To: <87abp4olb5.fsf@everybody.org> (Mark A. Hershberger's message of "Fri\, 23 Nov 2007 13\:42\:38 -0500") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83997 Archived-At: mah@everybody.org (Mark A. Hershberger) writes: > Andreas Schwab writes: > >> mah@everybody.org (Mark A. Hershberger) writes: >> >>> while (1) >>> { >>> /* Create the lock file, but not under the lock file name. */ >>> /* Give up if cannot do that. */ >>> +#ifndef HAVE_MKSTEMP >>> desc =3D open (tempname, O_WRONLY | O_CREAT | O_EXCL, 0666); >>> +#else >>> + desc =3D mkstemp (tempname); >>> +#endif >> >> That won't work since mkstemp modifies tempname in place, but can be >> called more than once here (the second call will return with EINVAL). > > There is only one call. Inside a loop. > If you look at the full patch, mktemp (not mkstemp) is called once if > HAVE_MKSTEMP is _not_ defined. Here, mkstemp (not mktemp) is called if > HAVE_MKSTEMP _is_ defined. Correct but irrelevant. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."