From: Andreas Schwab <schwab@suse.de>
Cc: rms@gnu.org, miles@gnu.org, handa@etl.go.jp, emacs-devel@gnu.org
Subject: Re: [simon.marshall@misys.com: FW: [21.1.90]: should coding be recalculated on revert-buffer?]
Date: Tue, 26 Feb 2002 23:44:39 +0100 [thread overview]
Message-ID: <je7kozsw14.fsf@sykes.suse.de> (raw)
In-Reply-To: <4098-Tue26Feb2002224400+0200-eliz@is.elta.co.il> ("Eli Zaretskii"'s message of "Tue, 26 Feb 2002 22:44:00 +0200")
"Eli Zaretskii" <eliz@is.elta.co.il> writes:
|> > Date: Tue, 26 Feb 2002 13:13:50 -0700 (MST)
|> > From: Richard Stallman <rms@gnu.org>
|> >
|> > It might be okay to do that inside revert-buffer, but even then I'd
|> > suggest to do it only for the EOL format, not for the base of the coding
|> > system, to keep the possible unintended consequences to a minimum.
|> >
|> > Why not do it for both aspects of the coding system, in revert?
|>
|> In principle, the two should go together, but in practice, the EOL
|> issue is much more simple and has less complications. So risky
|> decisions run lower risk with EOLs.
How about just setting buffer-file-coding-system to
last-coding-system-used in revert-buffer if coding-system-for-read is
non-nil? This way you can use `C-x RET c undecided' to force
re-detection.
2002-02-26 Andreas Schwab <schwab@suse.de>
* files.el (revert-buffer): Set `buffer-file-coding-system' if an
explicit coding system was requested.
--- files.el.~1.550.~ Thu Feb 7 11:22:19 2002
+++ files.el Tue Feb 26 23:42:23 2002
@@ -3006,7 +3006,11 @@
do all the work for this command. Otherwise, the hooks
`before-revert-hook' and `after-revert-hook' are run at the beginning
and the end, and if `revert-buffer-insert-file-contents-function' is
-non-nil, it is called instead of rereading visited file contents."
+non-nil, it is called instead of rereading visited file contents.
+
+Sets `buffer-file-coding-system' to the atually used coding system if
+`coding-system-for-read' is non-nil, unless reverting from the auto-save
+file."
;; I admit it's odd to reverse the sense of the prefix argument, but
;; there is a lot of code out there which assumes that the first
@@ -3075,7 +3079,12 @@
coding-system-for-read)))
;; Note that this preserves point in an intelligent way.
(insert-file-contents file-name (not auto-save-p)
- nil nil t))))
+ nil nil t))
+ ;; When a coding system was explicitly requested set
+ ;; the file coding system to what was actually used.
+ (if (and coding-system-for-read (not auto-save-p))
+ (setq buffer-file-coding-system
+ last-coding-system-used))))
;; Recompute the truename in case changes in symlinks
;; have changed the truename.
(setq buffer-file-truename
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE GmbH, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2002-02-26 22:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-25 7:01 [simon.marshall@misys.com: FW: [21.1.90]: should coding be recalculated on revert-buffer?] Kenichi Handa
2002-02-25 7:24 ` Stefan Monnier
2002-02-25 10:03 ` Eli Zaretskii
2002-02-25 10:31 ` Andreas Schwab
2002-02-25 11:04 ` Eli Zaretskii
2002-02-25 14:59 ` Stefan Monnier
2002-02-25 15:11 ` Eli Zaretskii
2002-02-26 20:13 ` Richard Stallman
2002-02-26 20:42 ` Eli Zaretskii
2002-02-27 5:50 ` Richard Stallman
2002-02-25 7:25 ` Miles Bader
2002-02-25 9:56 ` Eli Zaretskii
2002-02-26 20:13 ` Richard Stallman
2002-02-26 20:44 ` Eli Zaretskii
2002-02-26 22:44 ` Andreas Schwab [this message]
2002-02-27 5:50 ` Richard Stallman
2002-02-27 15:08 ` Andreas Schwab
2002-02-28 4:08 ` Richard Stallman
2002-02-27 10:19 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2002-02-25 11:58 Kenichi Handa
2002-02-25 12:07 ` Eli Zaretskii
2002-02-23 20:19 Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je7kozsw14.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=emacs-devel@gnu.org \
--cc=handa@etl.go.jp \
--cc=miles@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).