Re: emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.

Re: emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.

[Glenn Morris]

John Wiegley wrote:

> branch: emacs-25
> commit 97abf9273a80e0890b4756ec4d09d8bfe4077bba
> Author: foudfou <foudil.newbie+git@gmail.com>
> Commit: John Wiegley <johnw@newartisans.com>
>
>     * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.

The convention is that the commit message should describe the changes to
individual functions, variables etc. Also "Copyright-paperwork-exempt: yes"
is missing in this case. Also I believe that real names are preferred
unless the author actively wants to use a pseudonym.

(Normally you run 'make change-history' and fix these things in the
generated ChangeLog, but that remains inoperable for non-master branches.)

Finally maybe it merits a NEWS entry, I dunno (did not look at the
actual substance of the patch).

Re: emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.

[John Wiegley]

>>>>> Glenn Morris <rgm@gnu.org> writes:

> The convention is that the commit message should describe the changes to
> individual functions, variables etc. Also "Copyright-paperwork-exempt: yes"
> is missing in this case. Also I believe that real names are preferred unless
> the author actively wants to use a pseudonym.

> (Normally you run 'make change-history' and fix these things in the
> generated ChangeLog, but that remains inoperable for non-master branches.)

> Finally maybe it merits a NEWS entry, I dunno (did not look at the actual
> substance of the patch).

Thanks, Glenn, I'll do the followup work on this.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Tue, 15 Dec 2015 03:19:44 -0500
> Cc: johnw@newartisans.com
> 
> John Wiegley wrote:
> 
> > branch: emacs-25
> > commit 97abf9273a80e0890b4756ec4d09d8bfe4077bba
> > Author: foudfou <foudil.newbie+git@gmail.com>
> > Commit: John Wiegley <johnw@newartisans.com>
> >
> >     * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.
> 
> The convention is that the commit message should describe the changes to
> individual functions, variables etc. Also "Copyright-paperwork-exempt: yes"
> is missing in this case. Also I believe that real names are preferred
> unless the author actively wants to use a pseudonym.

Right, all this (and more) is in CONTRIBUTE.

Re: emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.

[John Wiegley]

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

>> The convention is that the commit message should describe the changes to
>> individual functions, variables etc. Also "Copyright-paperwork-exempt: yes"
>> is missing in this case. Also I believe that real names are preferred
>> unless the author actively wants to use a pseudonym.

> Right, all this (and more) is in CONTRIBUTE.

Right, I think I got caught up in making sure the copyright assignments were
all in order, then forgot to do due diligence on the form of the contribution
itself.

Hand = slapped. Puts CONTRIBUTE on tonight's reading list. :)

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2