From: Glenn Morris <rgm@gnu.org>
To: emacs-devel@gnu.org
Cc: johnw@newartisans.com
Subject: Re: emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.
Date: Tue, 15 Dec 2015 03:19:44 -0500 [thread overview]
Message-ID: <j0bn9si0nz.fsf@fencepost.gnu.org> (raw)
In-Reply-To: E1a8ZdA-0003rh-E8@vcs.savannah.gnu.org
John Wiegley wrote:
> branch: emacs-25
> commit 97abf9273a80e0890b4756ec4d09d8bfe4077bba
> Author: foudfou <foudil.newbie+git@gmail.com>
> Commit: John Wiegley <johnw@newartisans.com>
>
> * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.
The convention is that the commit message should describe the changes to
individual functions, variables etc. Also "Copyright-paperwork-exempt: yes"
is missing in this case. Also I believe that real names are preferred
unless the author actively wants to use a pseudonym.
(Normally you run 'make change-history' and fix these things in the
generated ChangeLog, but that remains inoperable for non-master branches.)
Finally maybe it merits a NEWS entry, I dunno (did not look at the
actual substance of the patch).
next parent reply other threads:[~2015-12-15 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151214202200.14819.23782@vcs.savannah.gnu.org>
[not found] ` <E1a8ZdA-0003rh-E8@vcs.savannah.gnu.org>
2015-12-15 8:19 ` Glenn Morris [this message]
2015-12-15 15:23 ` emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region John Wiegley
2015-12-15 16:09 ` Eli Zaretskii
2015-12-15 18:00 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=j0bn9si0nz.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=johnw@newartisans.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).