From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: [salve@debian.org: lisp/mail/supercite.el: sc-select-attribution logic is broken (patch included)] Date: Thu, 26 May 2005 18:32:35 +0100 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1117129013 30614 80.91.229.2 (26 May 2005 17:36:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 26 May 2005 17:36:53 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 26 19:36:44 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DbMFl-0003jt-0l for ged-emacs-devel@m.gmane.org; Thu, 26 May 2005 19:34:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DbMJr-0007e8-Mt for ged-emacs-devel@m.gmane.org; Thu, 26 May 2005 13:38:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DbMIn-0006Lr-2g for emacs-devel@gnu.org; Thu, 26 May 2005 13:37:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DbMIg-0006EX-2Z for emacs-devel@gnu.org; Thu, 26 May 2005 13:37:42 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DbMIf-00069V-PV for emacs-devel@gnu.org; Thu, 26 May 2005 13:37:41 -0400 Original-Received: from [131.111.8.130] (helo=ppsw-0.csi.cam.ac.uk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DbMEW-0006C9-UM; Thu, 26 May 2005 13:33:25 -0400 X-Cam-SpamDetails: Not scanned X-Cam-AntiVirus: No virus found X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Original-Received: from cass41.ast.cam.ac.uk ([131.111.69.186]:61843) by ppsw-0.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.130]:25) with esmtp id 1DbMDj-0005Ye-2V (Exim 4.51) (return-path ); Thu, 26 May 2005 18:32:35 +0100 Original-Received: from xserv1.ast.cam.ac.uk (xserv1.ast.cam.ac.uk [131.111.69.235]) by cass41.ast.cam.ac.uk (8.12.10+Sun/8.12.10) with ESMTP id j4QHWZoL002905; Thu, 26 May 2005 18:32:35 +0100 (BST) Original-Received: from xalph3.ast.cam.ac.uk (xpc14.ast.cam.ac.uk [131.111.69.34]) by xserv1.ast.cam.ac.uk (Postfix) with ESMTP id 54EBE172AD7; Thu, 26 May 2005 18:32:35 +0100 (BST) Original-To: rms@gnu.org X-Spook: hijack ASG ANO KKK Talaa' al-Fateh Kashmir ammunition X-Ran: 7AZjlG7ghDGF1N_k<6~fdY=.c});nMH'm#pZJ)B3MiX^89JTNI;4$WBgUJ#EvJKdM=@vFb X-Hue: dark turquoise X-Attribution: GM Mail-Followup-To: rms@gnu.org, emacs-devel@gnu.org In-Reply-To: (Richard Stallman's message of "Wed, 25 May 2005 11:02:19 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37718 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37718 Actually, the following patch is better than the first one I sent. *** supercite.el 14 May 2005 11:27:40 -0000 1.44 --- supercite.el 26 May 2005 17:29:26 -0000 *************** *** 1182,1189 **** (setq attribution attrib attriblist nil)) ((listp attrib) ! (setq attribution (eval attrib) ! attriblist nil)) (t (error "%s did not evaluate to a string or list!" "sc-attrib-selection-list")) ))) --- 1182,1192 ---- (setq attribution attrib attriblist nil)) ((listp attrib) ! (setq attribution (eval attrib)) ! (if (stringp attribution) ! (setq attriblist nil) ! (setq attribution nil ! attriblist (cdr attriblist)))) (t (error "%s did not evaluate to a string or list!" "sc-attrib-selection-list")) )))