unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon Josefsson <jas@extundo.com>
Subject: Re: "patch" to smtpmail.el
Date: Tue, 07 May 2002 19:09:51 +0200	[thread overview]
Message-ID: <iluhelj995s.fsf@extundo.com> (raw)
In-Reply-To: <iluznzc9brs.fsf@extundo.com> (Simon Josefsson's message of "Tue, 07 May 2002 18:13:27 +0200")

Could someone please commit this?  It was acknowledged to work.  It
also fixes :version of an older patch.

Is it possible to get CVS write permission, btw?  How do I get that?

2002-05-07  Simon Josefsson  <jas@extundo.com>

	* mail/smtpmail.el (smtpmail-send-it): Use user-mail-address from
	calling buffer.
	(smtpmail-auth-credentials): Bump :version to 21.4 (21.3 will not
	have the patch).

Index: smtpmail.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/mail/smtpmail.el,v
retrieving revision 1.41
diff -u -p -u -w -r1.41 smtpmail.el
--- smtpmail.el	26 Apr 2002 18:59:08 -0000	1.41
+++ smtpmail.el	7 May 2002 17:09:05 -0000
@@ -165,7 +165,7 @@ looks like `user@realm'."
 		       (string  :tag "Username")
 		       (choice (const :tag "Query when needed" nil)
 				       (string  :tag "Password")))))
-  :version "21.3"
+  :version "21.4"
   :group 'smtpmail)
 
 (defcustom smtpmail-starttls-credentials '(("" 25 "" ""))
@@ -218,6 +218,7 @@ This is relative to `smtpmail-queue-dir'
 	(case-fold-search nil)
 	delimline
 	(mailbuf (current-buffer))
+	(user-mail-address user-mail-address)
 	(smtpmail-code-conv-from
 	 (if enable-multibyte-characters
 	     (let ((sendmail-coding-system smtpmail-code-conv-from))

Simon Josefsson <jas@extundo.com> writes:

> Gareth Owen <usenet@gwowen.freeserve.co.uk> writes:
>
>> This makes the process-buffer inherit user-mail-address from the message
>> buffer.  Useful to stop your "real" email address leaking out in headers 
>> like X-From and X-Return-Path headers added by the SMTP agent.
>>
>> BCC'd to maintainer.
>
> Does this patch work instead?
>
> Index: smtpmail.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/mail/smtpmail.el,v
> retrieving revision 1.41
> diff -u -p -u -w -r1.41 smtpmail.el
> --- smtpmail.el	26 Apr 2002 18:59:08 -0000	1.41
> +++ smtpmail.el	7 May 2002 16:13:26 -0000
> @@ -218,6 +218,7 @@ This is relative to `smtpmail-queue-dir'
>  	(case-fold-search nil)
>  	delimline
>  	(mailbuf (current-buffer))
> +	(user-mail-address user-mail-address)
>  	(smtpmail-code-conv-from
>  	 (if enable-multibyte-characters
>  	     (let ((sendmail-coding-system smtpmail-code-conv-from))

       reply	other threads:[~2002-05-07 17:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <r5ioffsf6er.fsf@gill.maths.keele.ac.uk>
     [not found] ` <iluznzc9brs.fsf@extundo.com>
2002-05-07 17:09   ` Simon Josefsson [this message]
2002-05-08  4:59     ` "patch" to smtpmail.el Eli Zaretskii
2002-05-09 14:59     ` Richard Stallman
2002-05-09 17:40       ` Simon Josefsson
2002-05-11  6:30         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iluhelj995s.fsf@extundo.com \
    --to=jas@extundo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).