From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.devel Subject: Re: Adding Flycheck to NonGNU ELPA Date: Fri, 23 Feb 2024 11:20:00 -0500 Message-ID: References: <41bdb94a-3f9c-4b46-b061-b0c5e31a403e@app.fastmail.com> <871q98bb7q.fsf@posteo.net> <72490bec-175b-46b6-aaf9-153b3c242b70@app.fastmail.com> <87le7g9tg9.fsf@posteo.net> <874je413vo.fsf@tanaka.verona.se> <87le7f1hlq.fsf@posteo.net> <69829f55-511b-4543-9a1b-938a5e8ac08c@gutov.dev> <87zfvtwy2w.fsf@posteo.net> <706be920-cbd4-42d8-8c76-3abdb7e7b026@gutov.dev> <87edd5wv59.fsf@posteo.net> <553db84b-e29b-4622-a02d-77e250f2d1d2@gutov.dev> <6F5EE2C9-D4C9-46BB-A478-74A360059B90@sanityinc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31273"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Steve Purcell , Stefan Kangas , Stefan Monnier , Philip Kaludercic , joakim@verona.se, Bozhidar Batsov , Emacs Devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 23 18:06:23 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdZ0B-0007sc-3V for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Feb 2024 18:06:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdYzq-0005od-KD; Fri, 23 Feb 2024 12:06:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYHN-0003bV-C3 for emacs-devel@gnu.org; Fri, 23 Feb 2024 11:20:05 -0500 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYHK-00057l-JH for emacs-devel@gnu.org; Fri, 23 Feb 2024 11:20:05 -0500 In-Reply-To: (Dmitry Gutov's message of "Thu, 22 Feb 2024 16:29:14 +0200") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1708705200; bh=9UO1hmuJgfnkOah0J0q+II9kHiTOcN7qcUF+1Oe092o=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=vF/iVK2MDd86WJ4m/hjoEW9xUSH8ZGTWdOBNTbU0wLN9mTe5/iBHsv71ZKQgwNKpY tjwT0zmtALcvqRe0kpXFi8WDBO52+wIAGoyuI8HlrOIOVho7VDUEwVRivVZKQJ9ezJ Db5kdSaJHxXP6gXu735Eb2vgiyiJjeJco1a+iEeoBEwtDl7OKHJE68zwZAgL8cSLES dqQILhP5gEPHUohWca5DKOlJIjUT+REmrtRgH0r8A72P3DRi89TW0rL8SBi6sY0SAo kk39A9TVDdmzOmv8KTARwoj9X7EhZELYAxK2jKi6hUkZJYUm9urvBQKQYqh5tBGgv+ Gatxia3wfss9Q== Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@janestreet.com; helo=mxout5.mail.janestreet.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 23 Feb 2024 11:50:32 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316473 Archived-At: Dmitry Gutov writes: > On 22/02/2024 12:14, Steve Purcell wrote: >>=20 >>> On 22 Feb 2024, at 03:16, Dmitry Gutov wrote: >>> >>> flymake-easy has another problem: IIUC it hasn't been updated for 10 ye= ars, and as such only uses the obsolete Flymake protocol (one we keep in fl= ymake-proc.el for compatibility). It also employs defadvice. >> The defadvice issue is easily fixed, but in general I can=E2=80=99t tell= if >> the package is defunct or would still be useful for people if it had >> a refresh. I suspect the latter. > > I think there is demand for it, but code-wise, it might need a full rewri= te. > > It also might make sense to contribute the improved helper to > flymake.el directly, rather than have it as an external package - then > the built-in modes could also use it. > > Because what I have to do at the moment, is copy ruby-flymake--helper > with minor variations to use for each backend, and that's not ideal. > > Meanwhile the users of flymake-easy who target older versions of > Flymake (including the current release) could continue to use the > existing version, since the obsolete API is still supported (I think), > just not quite recommended. >From looking at ruby-flymake--helper, maybe it would be best to have a new helper for working with processes. It looks like ruby-flymake--helper just wants to: 1. Send the current buffer text to a process. 2. When the process exits cleanly, call a callback with all the process's output. It seems like we could add a helper that supports that. Then ruby-flymake--helper would disappear in favor of some process-run-and-call function. Or... IMO, even better than a helper would be using Elisp threads for this. Then there's no need for any callback stuff. Really, threads are a natural fit for flymake, since flymake already provides a UI which can display data computed asynchronously by threads, and that's IMO the hardest part of using threads.