From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.devel Subject: Re: Adding support for xref jumping to headers/interfaces Date: Wed, 08 Nov 2023 12:40:38 -0500 Message-ID: References: <83h6uv47e8.fsf@gnu.org> <4639d7ca-2109-864c-33c0-38e65f26f262@yandex.ru> <835ybb3txt.fsf@gnu.org> <83wn3q311i.fsf@gnu.org> <412afa2d-5dbc-52da-39c4-99be3873929c@yandex.ru> <83o7p20wdi.fsf@gnu.org> <72b09256-5a1b-8962-9e3c-7d2ffd0dc0d7@yandex.ru> <83ilf925n8.fsf@gnu.org> <95afa441-18ae-e62a-be16-be73a545bbba@yandex.ru> <65a16247-1b1a-149c-b413-71612f88f184@yandex.ru> <9377bf2b-13ed-8d86-4294-0b88e6808d80@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31237"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:ekSgLBGRjGbC6tpseiSvmabkIaA= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 08 18:45:19 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0mcA-0007xG-TX for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Nov 2023 18:45:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0mbi-0004yW-V8; Wed, 08 Nov 2023 12:44:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0mXp-00043S-1V for emacs-devel@gnu.org; Wed, 08 Nov 2023 12:40:49 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0mXn-0001Yi-HE for emacs-devel@gnu.org; Wed, 08 Nov 2023 12:40:48 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1r0mXl-0002UH-F3 for emacs-devel@gnu.org; Wed, 08 Nov 2023 18:40:45 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 08 Nov 2023 12:44:49 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312354 Archived-At: João Távora writes: > On Wed, Nov 8, 2023, 16:40 Spencer Baugh wrote: > > João Távora writes: > > On Tue, Nov 7, 2023 at 11:18 PM Dmitry Gutov wrote: > >> What I meant is, using it with the Elisp implementation didn't > >> convince me of the usefulness of the feature. Perhaps you disagree? > >> > >> Or it would be nice to hear from someone who have tried out Eglot's > >> integration and found more upsides there. > > > > If you want that to happen, the only realistic way to have good > > feedback from anyone else other than emacs-devel nerds like me and you > > is to release an Eglot version with this feature, which we can change > > later (even non-backward-compatibly, within a reasonable time frame). > > I tried the Eglot integration, my comments elsewhere are inspired by > that. > > Can you point me to this "elsewhere"? Elsewhere in this thread - my message on Tue, 07 Nov 2023 11:51:49 -0500 > I found it rather clumsy out of the box. > > What exactly is clumsy? Please state the command you used and what the clumsy effects were. Specifically xref-find-extras is clumsy, because it's annoying to have to type the full "kind" in to request a specific "kind" of definition. eglot-find-{declaration,implementation,typeDefinition} is good as always. > However, it works well with an > approach of adding bindings for individual kinds, as is currently how I > (and other Eglot users at Jane Street, and presumably most other Eglot > users everywhere) use Eglot. So that compatibility with an > already-common approach is an upside of this integration. > > Bindings to what commands exactly? eglot-find-{declaration,implementation,typeDefinition} > However, the alternative UI which shows all kinds of definitions in a > single buffer does not exist for Eglot in the same way it exists for > Elisp. So... I can't really compare it to that. > > What "alternative UI" are you talking about exactly? How can I trigger it for Elisp? Please give a full example as I don't know what > you are taking about. In Elisp, M-. (xref-find-definitions) already shows all the kinds of definitions that are requestable through xref-find-extras. But there's no similar way to show all kinds of definitions for Eglot - M-. only includes the proper definition, not the declaration and typeDefinition and so on. I know you would prefer not to implement such a thing, I'm just explaining for Dmitry that since this kind of UI doesn't exist, I can't compare xref-find-extras against that kind of UI for Eglot in the same way that I can with Elisp.