From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Francis Litterio Newsgroups: gmane.emacs.devel Subject: Re: buff-menu.el no longer runs buffer-menu-mode-hook Date: Tue, 02 Sep 2008 22:55:29 -0400 Message-ID: References: <48BDF0DE.70603@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1220410836 3863 80.91.229.12 (3 Sep 2008 03:00:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Sep 2008 03:00:36 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 03 05:01:30 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kaicc-0004m7-4R for ged-emacs-devel@m.gmane.org; Wed, 03 Sep 2008 05:01:30 +0200 Original-Received: from localhost ([127.0.0.1]:56728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kaibd-000307-4v for ged-emacs-devel@m.gmane.org; Tue, 02 Sep 2008 23:00:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kaiba-0002yu-13 for emacs-devel@gnu.org; Tue, 02 Sep 2008 23:00:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KaibY-0002wz-Ej for emacs-devel@gnu.org; Tue, 02 Sep 2008 23:00:25 -0400 Original-Received: from [199.232.76.173] (port=51272 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaibY-0002wh-9X for emacs-devel@gnu.org; Tue, 02 Sep 2008 23:00:24 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:44480 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KaibX-0004Lq-Td for emacs-devel@gnu.org; Tue, 02 Sep 2008 23:00:24 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KaibP-0002MW-Q9 for emacs-devel@gnu.org; Wed, 03 Sep 2008 03:00:16 +0000 Original-Received: from c-24-91-152-98.hsd1.ma.comcast.net ([24.91.152.98]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 03 Sep 2008 03:00:15 +0000 Original-Received: from flitterio by c-24-91-152-98.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 03 Sep 2008 03:00:15 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 22 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-24-91-152-98.hsd1.ma.comcast.net X-Draft-From: ("nntp+news.gmane.org:gmane.emacs.devel" 103461) X-Random-Quote: I am not one of those who in expressing opinions confine themselves to facts. -- Mark Twain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (windows-nt) Cancel-Lock: sha1:emIqf5FD7+ytlcEMSv3IPyFE8YQ= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:103473 Archived-At: Lennart Borgman (gmail) wrote: > Francis Litterio wrote: >> In CVS Emacs, function list-buffers no longer runs the hook >> buffer-menu-mode-hook after creating the Buffer-menu-mode buffer. This >> used to happen. >> >> In fact, there is no longer any reference to variable >> buffer-menu-mode-hook in lisp/buff-menu.el. I don't know if >> define-derived-mode is supposed to define it and arrange for it to be >> run, but it is not being run. > > It is supposed to be run and defined by define-derived-mode but it looks > like there is a mismatch in the name (buffer-menu-mode-hook instead of > Buffer-menu-mode-hook). Thanks for catching that obvious solution. It works if I pass the symbol 'Buffer-menu-mode-hook (with a capital 'B') to add-hook. Still, this is an incompatible change that breaks existing Elisp code. -- Fran