unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Francis Litterio <flitterio@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: buff-menu.el no longer runs buffer-menu-mode-hook
Date: Tue, 02 Sep 2008 22:55:29 -0400	[thread overview]
Message-ID: <i5i6od36j5mz.fsf@gmail.com> (raw)
In-Reply-To: 48BDF0DE.70603@gmail.com

Lennart Borgman (gmail) wrote:

> Francis Litterio wrote:
>> In CVS Emacs, function list-buffers no longer runs the hook
>> buffer-menu-mode-hook after creating the Buffer-menu-mode buffer.  This
>> used to happen.
>> 
>> In fact, there is no longer any reference to variable
>> buffer-menu-mode-hook in lisp/buff-menu.el.  I don't know if
>> define-derived-mode is supposed to define it and arrange for it to be
>> run, but it is not being run.
>
> It is supposed to be run and defined by define-derived-mode but it looks
> like there is a mismatch in the name (buffer-menu-mode-hook instead of
> Buffer-menu-mode-hook).

Thanks for catching that obvious solution.  It works if I pass the
symbol 'Buffer-menu-mode-hook (with a capital 'B') to add-hook.

Still, this is an incompatible change that breaks existing Elisp code.
--
Fran





  reply	other threads:[~2008-09-03  2:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03  1:45 buff-menu.el no longer runs buffer-menu-mode-hook Francis Litterio
2008-09-03  2:05 ` Lennart Borgman (gmail)
2008-09-03  2:55   ` Francis Litterio [this message]
2008-09-03  4:07 ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=i5i6od36j5mz.fsf@gmail.com \
    --to=flitterio@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).