From: Glenn Morris <rgm@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: doc-view.patch waiting for installation
Date: Sun, 28 Oct 2007 21:52:44 -0400 [thread overview]
Message-ID: <i2hckait5f.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87k5pa407o.fsf_-_@baldur.tsdh.de> (Tassilo Horn's message of "Fri, 26 Oct 2007 12:52:27 +0200")
Tassilo Horn wrote:
> since my patch (<87y7dsh6xt.fsf@baldur.tsdh.de>) was approved by Stefan
> and I made all changes suggested by RMS and others, would somebody go on
> and install it?
The supplied ChangeLog entry seems incomplete. Eg
doc-view-toggle-display is not mentioned, nor is not requiring 'cl any
more, nor doc-view-previous-major-mode, the stuff about "Use
image-mode scrolling for mouse-wheel." seems not apply, etc.
I got as far as this version:
2007-10-29 Tassilo Horn <tassilo@member.fsf.org>
* doc-view.el: No longer require cl at compile time.
(doc-view-current-display): Remove variable.
(doc-view-previous-major-mode): New internal variable.
(doc-view-mode-map): New binding K to kill the converter process.
Remove doc-view-edit-doc binding.
(doc-view-mode-text-map): Remove keymap.
(doc-view-minor-mode-map): New keymap.
(doc-view-kill-proc): Set
doc-view-current-converter-process nil after killing process.
(doc-view-current-cache-dir): Better cache dir naming.
(doc-view-remove-if): New function.
(doc-view-search-next-match, doc-view-search-previous-match):
Use it.
(doc-view-pdf/ps->png): Timer calls d-v-display instead
d-v-display-maybe.
(doc-view-ps->pdf): Resort args to make ps2pdf happy.
(doc-view-convert-current-doc): Use
doc-view-current-cache-dir as a function, not a variable.
(doc-view-display-maybe): Remove function.
(doc-view-buffer-message): Mention new binding K.
(doc-view-toggle-display): Do stuff. *** FIXME
(doc-view-mode): Remove text/image switching code.
Use plain defun.
(doc-view-minor-mode): New minor mode.
* progmodes/ps-mode.el (ps-mode): Enable doc-view-minor-mode.
next prev parent reply other threads:[~2007-10-29 1:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-21 2:38 doc-view compilation warnings Miles Bader
2007-10-21 8:55 ` Tassilo Horn
2007-10-22 9:00 ` Richard Stallman
2007-10-23 13:32 ` Tassilo Horn
2007-10-23 14:30 ` Dan Nicolaescu
2007-10-23 15:54 ` Tassilo Horn
2007-10-23 16:07 ` Dan Nicolaescu
2007-10-23 17:50 ` Tassilo Horn
2007-10-23 18:35 ` Dan Nicolaescu
2007-10-23 18:41 ` Tassilo Horn
2007-10-23 19:00 ` Stefan Monnier
2007-10-23 20:00 ` Tassilo Horn
2007-10-23 21:53 ` Stefan Monnier
2007-10-24 7:59 ` Tassilo Horn
2007-10-24 11:40 ` Tassilo Horn
2007-10-24 15:24 ` Tassilo Horn
2007-10-26 10:52 ` doc-view.patch waiting for installation (was: doc-view compilation warnings) Tassilo Horn
2007-10-29 1:52 ` Glenn Morris [this message]
2007-10-29 9:36 ` doc-view.patch waiting for installation Tassilo Horn
2007-10-30 6:33 ` Glenn Morris
2007-10-30 18:07 ` Case folding for auto-mode-alist (was: doc-view.patch waiting for installation) Reiner Steib
2007-10-30 19:00 ` Case folding for auto-mode-alist Stefan Monnier
2007-10-31 7:47 ` Richard Stallman
2007-10-31 15:19 ` Stefan Monnier
2007-10-31 15:30 ` David Kastrup
2007-10-31 16:17 ` Stefan Monnier
2007-10-24 13:55 ` doc-view compilation warnings Stefan Monnier
2007-10-24 14:32 ` Tassilo Horn
2007-10-24 8:33 ` Richard Stallman
2007-10-24 8:32 ` Richard Stallman
2007-10-24 8:32 ` Richard Stallman
2007-10-24 8:32 ` Richard Stallman
2007-10-24 2:49 ` Richard Stallman
2007-10-24 2:49 ` Richard Stallman
2007-10-24 8:11 ` Tassilo Horn
2007-10-24 8:19 ` David Kastrup
2007-10-25 2:10 ` Richard Stallman
2007-10-25 8:09 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=i2hckait5f.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).