From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Byte compiler and eval-when-compile Date: Thu, 18 Oct 2012 16:11:17 -0400 Message-ID: References: <87a9vn7lhv.fsf@engster.org> <87626b7d02.fsf@engster.org> <876267zk1u.fsf@engster.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1350591088 25015 80.91.229.3 (18 Oct 2012 20:11:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Oct 2012 20:11:28 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 18 22:11:36 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TOwRF-0000Z5-2B for ged-emacs-devel@m.gmane.org; Thu, 18 Oct 2012 22:11:29 +0200 Original-Received: from localhost ([::1]:36644 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOwR7-00011F-SS for ged-emacs-devel@m.gmane.org; Thu, 18 Oct 2012 16:11:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOwR5-0000y2-Tm for emacs-devel@gnu.org; Thu, 18 Oct 2012 16:11:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOwR4-0003dX-Vu for emacs-devel@gnu.org; Thu, 18 Oct 2012 16:11:19 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:33300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOwR4-0003dS-TD for emacs-devel@gnu.org; Thu, 18 Oct 2012 16:11:18 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TOwR3-0007ql-Sv; Thu, 18 Oct 2012 16:11:17 -0400 X-Spook: arrangements Firefly Sundevil INS mania rail gun credit X-Ran: }b4CM*VuB8rrTYBb@%^I![~?lFc+n-NQ5D|~?U-`LY@HIADeILvE'Un-=KJlHj"E[q>h2X X-Hue: red X-Attribution: GM In-Reply-To: (Glenn Morris's message of "Thu, 18 Oct 2012 15:53:02 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154423 Archived-At: It might be better to simply move the boundp test inside eieio-update-lisp-imenu-expression and always define the function. Actually, the whole thing looks both pointless and bogus anyway. The right thing in Emacs would be to modify the definition of lisp-imenu-generic-expression in lisp-mode.el directly to add defmethod, and this has aleady been done. And the regexp optimization means that "|advice\\" does not appear in lisp-imenu-generic-expression anyway, since at least Emacs 22.1.