23.0.60; Regression: Vertical border face not working

23.0.60; Regression: Vertical border face not working

[Len Trigg]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:


I built emacs from CVS (updated today March 1st), and my vertical
border face is no longer working (I am using emacs in a tty).  The
vertical border face shows as underline, instead of my custom defined
face.  My previous emacs CVS build (from approximately a couple of
weeks ago) was fine.


Cheers,
Len.




If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/home2/len/local/share/emacs/23.0.60/etc/DEBUG for instructions.


In GNU Emacs 23.0.60.2 (i686-pc-linux-gnu, GTK+ Version 2.10.4)
 of 2008-03-01 on noir
configured using `configure  '--with-x-toolkit=gtk' '--prefix=/home2/len/local''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_NZ
  value of $XMODIFIERS: @im=none
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

Major mode: Custom

Minor modes in effect:
  pmwiki-minor-mode: t
  erc-autoaway-mode: t
  erc-button-mode: t
  erc-ring-mode: t
  erc-track-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-pcomplete-mode: t
  display-time-mode: t
  delete-selection-mode: t
  show-paren-mode: t
  pc-selection-mode: t
  tool-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
TAB TAB RET RET ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 
6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 
~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ 
ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC 
[ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC O B ESC O B 
ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC 
O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B 
ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC 
O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B 
ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC 
O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B 
ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC 
O B ESC O B ESC O B ESC O B ESC O B ESC O A ESC O A 
ESC O A ESC O A ESC O A ESC O A ESC O A C-@ C-n C-n 
C-n C-p C-p C-n C-n ESC w C-n C-p ESC x r e p o r TAB 
g DEL b u g TAB RET

Recent messages:
Unable to load color "brightcyan"
Unable to load color "brightyellow"
Unable to load color "brightcyan"
Unable to load color "brightmagenta"
Unable to load color "brightwhite"
Unable to load color "brightcyan"
Unable to load color "brightgreen"
Unable to load color "brightred"
Mark set
Region saved

Re: 23.0.60; Regression: Vertical border face not working

[Eli Zaretskii]

> Date: Sat, 01 Mar 2008 15:44:00 +1300
> From: Len Trigg <lenbok@gmail.com>
> Cc: 
> 
> 
> I built emacs from CVS (updated today March 1st), and my vertical
> border face is no longer working (I am using emacs in a tty).  The
> vertical border face shows as underline, instead of my custom defined
> face.  My previous emacs CVS build (from approximately a couple of
> weeks ago) was fine.

Can you show us your definition of that face?  A change in the face
handling was recently committed to CVS, and I suspect you either
define a face in a way that is no longer valid, or maybe your face
exposes a bug in that change.

Thanks.

Re: 23.0.60; Regression: Vertical border face not working

[Len Trigg]

Eli Zaretskii wrote:
> Can you show us your definition of that face?  A change in the face
> handling was recently committed to CVS, and I suspect you either
> define a face in a way that is no longer valid, or maybe your face
> exposes a bug in that change.

Hmmm, looks to be my bad.  I found this in my .emacs, given to me by
emacs-dev people from back when the vertical border face was initially
implemented...

;; TTY-emacs: Use mode line face for vertical border
(set-display-table-slot standard-display-table
                        'vertical-border
                        (let* ((face 'mode-line)
                               (face-offset (lsh (face-id face) 19)))
                          (+ face-offset ?|)))


I commented this out, and now the vertical border displays correctly.


Cheers,
Len.

Re: 23.0.60; Regression: Vertical border face not working

[Eli Zaretskii]

> Date: Mon, 03 Mar 2008 09:17:25 +1300
> From: Len Trigg <lenbok@gmail.com>
> Cc: emacs-pretest-bug@gnu.org
> 
> ;; TTY-emacs: Use mode line face for vertical border
> (set-display-table-slot standard-display-table
>                         'vertical-border
>                         (let* ((face 'mode-line)
>                                (face-offset (lsh (face-id face) 19)))
>                           (+ face-offset ?|)))
> 
> 
> I commented this out, and now the vertical border displays correctly.

Yes, this is precisely the change that was made: adding faces to
characters now works differently.

Re: 23.0.60; Regression: Vertical border face not working

[Kim F. Storm]

>> I commented this out, and now the vertical border displays correctly.
>
> Yes, this is precisely the change that was made: adding faces to
> characters now works differently.

This should work:

;; TTY-emacs: Use mode line face for vertical border
(set-display-table-slot standard-display-table
                        'vertical-border
                        (make-glyph-code ?| 'mode-line))


-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk