From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] POSIX ACL support Date: Mon, 19 Nov 2012 12:11:38 -0500 Message-ID: References: <878v9yr1h1.fsf@silenus.orebokech.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1353345108 28878 80.91.229.3 (19 Nov 2012 17:11:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Nov 2012 17:11:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Romain Francoise Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 19 18:11:58 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TaUsz-0005K2-3O for ged-emacs-devel@m.gmane.org; Mon, 19 Nov 2012 18:11:53 +0100 Original-Received: from localhost ([::1]:60071 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaUso-0004SB-MI for ged-emacs-devel@m.gmane.org; Mon, 19 Nov 2012 12:11:42 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaUsm-0004Ro-EI for emacs-devel@gnu.org; Mon, 19 Nov 2012 12:11:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TaUsl-0004ee-CJ for emacs-devel@gnu.org; Mon, 19 Nov 2012 12:11:40 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaUsl-0004ea-8o for emacs-devel@gnu.org; Mon, 19 Nov 2012 12:11:39 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TaUsk-0003ax-7c; Mon, 19 Nov 2012 12:11:38 -0500 X-Spook: cryptographic NATO Fortezza AGT. AMME embassy Mafia ANC X-Ran: O4"Y,6-N7dRXp?$*rkpFK"NgbF- List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154957 Archived-At: Romain Francoise wrote: > The following patch adds support for preserving POSIX ACL entries of > files, which at the moment are lost when Emacs saves a buffer (unless > `backup-by-copying' is set). Thanks for writing this. It is definitely needed IMO. > -(defun backup-buffer-copy (from-name to-name modes context) > +(defun backup-buffer-copy (from-name to-name modes context acl) [and several other such] This is really a general comment, not an issue with your patch in particular, so don't let it distract. I just wonder if it is possible to find a different way to pass this information around, so that we don't need to have an ever increasing list of function arguments and return values (preserve-this, preserve-that, preserve-the-other, etc...). I don't have a good suggestion for how to do that. (I have a vague memory this was mentioned when SELinux was added.)