unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* vc-git-annotate vs configured date format
@ 2009-07-28 19:51 Karl Chen
  2009-07-29  2:41 ` Stephen J. Turnbull
  2009-07-29  6:03 ` Dan Nicolaescu
  0 siblings, 2 replies; 6+ messages in thread
From: Karl Chen @ 2009-07-28 19:51 UTC (permalink / raw)
  To: Emacs Developement List


I have this in my .gitconfig:
    [blame]
            date = short

Which causes emacs' vc-annotate to not work correctly, because
vc-git-annotate-time hardcodes the regexp it looks for assuming
it's date=iso.

What do you think about getting vc-git-annotate to work regardless
of the blame.date setting?

An easy fix would be to just add --date=iso to the command-line.
But ideally Emacs would be able to parse other date formats also.
Date=short would be pretty easy to check for since it's a subset
of date=iso; others might be harder.

Thanks,
Karl




^ permalink raw reply	[flat|nested] 6+ messages in thread

* vc-git-annotate vs configured date format
  2009-07-28 19:51 vc-git-annotate vs configured date format Karl Chen
@ 2009-07-29  2:41 ` Stephen J. Turnbull
  2009-07-29  6:03 ` Dan Nicolaescu
  1 sibling, 0 replies; 6+ messages in thread
From: Stephen J. Turnbull @ 2009-07-29  2:41 UTC (permalink / raw)
  To: Karl Chen; +Cc: Emacs Development List

Karl Chen writes:

 > What do you think about getting vc-git-annotate to work regardless
 > of the blame.date setting?
 > 
 > An easy fix would be to just add --date=iso to the command-line.

It's also the correct fix.

 > But ideally Emacs would be able to parse other date formats also.

One man's ideal is another's madness.  See Alan's rant on C++ syntax.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: vc-git-annotate vs configured date format
  2009-07-28 19:51 vc-git-annotate vs configured date format Karl Chen
  2009-07-29  2:41 ` Stephen J. Turnbull
@ 2009-07-29  6:03 ` Dan Nicolaescu
  2009-07-29 15:21   ` Deniz Dogan
  2009-08-01  5:21   ` Karl Chen
  1 sibling, 2 replies; 6+ messages in thread
From: Dan Nicolaescu @ 2009-07-29  6:03 UTC (permalink / raw)
  To: Karl Chen; +Cc: Emacs Developement List

Karl Chen <Karl.Chen@quarl.org> writes:

  > I have this in my .gitconfig:
  >     [blame]
  >             date = short
  > 
  > Which causes emacs' vc-annotate to not work correctly, because
  > vc-git-annotate-time hardcodes the regexp it looks for assuming
  > it's date=iso.
  > 
  > What do you think about getting vc-git-annotate to work regardless
  > of the blame.date setting?

That sounds like TRTD.
Are there any other settings that affect the git blame output?




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: vc-git-annotate vs configured date format
  2009-07-29  6:03 ` Dan Nicolaescu
@ 2009-07-29 15:21   ` Deniz Dogan
  2009-07-30  1:40     ` Kevin Rodgers
  2009-08-01  5:21   ` Karl Chen
  1 sibling, 1 reply; 6+ messages in thread
From: Deniz Dogan @ 2009-07-29 15:21 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: Karl Chen, Emacs Developement List

2009/7/29 Dan Nicolaescu <dann@ics.uci.edu>:
> Karl Chen <Karl.Chen@quarl.org> writes:
> That sounds like TRTD.

Google failed miserably on this one... What's TRTD?

-- 
Deniz Dogan




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: vc-git-annotate vs configured date format
  2009-07-29 15:21   ` Deniz Dogan
@ 2009-07-30  1:40     ` Kevin Rodgers
  0 siblings, 0 replies; 6+ messages in thread
From: Kevin Rodgers @ 2009-07-30  1:40 UTC (permalink / raw)
  To: emacs-devel

Deniz Dogan wrote:
> 2009/7/29 Dan Nicolaescu <dann@ics.uci.edu>:
>> Karl Chen <Karl.Chen@quarl.org> writes:
>> That sounds like TRTD.
> 
> Google failed miserably on this one... What's TRTD?

The Right Thing to Do

-- 
Kevin Rodgers
Denver, Colorado, USA





^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: vc-git-annotate vs configured date format
  2009-07-29  6:03 ` Dan Nicolaescu
  2009-07-29 15:21   ` Deniz Dogan
@ 2009-08-01  5:21   ` Karl Chen
  1 sibling, 0 replies; 6+ messages in thread
From: Karl Chen @ 2009-08-01  5:21 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: Emacs Developement List

>>>>> On 2009-07-29 02:03 EDT, Dan Nicolaescu writes:

    Dan> Are there any other settings that affect the git blame
    Dan> output?

-C is a very useful option to git-blame, it'd be nice if Emacs
understood its output, and allowed configuring to use it.





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2009-08-01  5:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-28 19:51 vc-git-annotate vs configured date format Karl Chen
2009-07-29  2:41 ` Stephen J. Turnbull
2009-07-29  6:03 ` Dan Nicolaescu
2009-07-29 15:21   ` Deniz Dogan
2009-07-30  1:40     ` Kevin Rodgers
2009-08-01  5:21   ` Karl Chen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).