unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [BUG] Not following symlinks by default
@ 2013-07-28  9:14 Ramkumar Ramachandra
  2013-07-28 12:02 ` Ramkumar Ramachandra
  0 siblings, 1 reply; 5+ messages in thread
From: Ramkumar Ramachandra @ 2013-07-28  9:14 UTC (permalink / raw)
  To: Emacs Devel; +Cc: Duy Nguyễn

Hi,

I've spent many frustrating hours cornering this bug.  Here's a short
testcase to reproduce it:

  #!/bin/sh

  cd /tmp
  rm -rf z b
  mkdir z z/a z/b
  echo ha >z/a/file
  ln -s z/b
  cd b
  cat ../a/file
  emacs -Q ../a/file # buffer-file-name = /tmp/a/file

Why doesn't emacs behave like cat or vim?  Isn't this behavior a bad default?

Thanks.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BUG] Not following symlinks by default
  2013-07-28  9:14 [BUG] Not following symlinks by default Ramkumar Ramachandra
@ 2013-07-28 12:02 ` Ramkumar Ramachandra
  2013-07-28 18:42   ` Glenn Morris
  0 siblings, 1 reply; 5+ messages in thread
From: Ramkumar Ramachandra @ 2013-07-28 12:02 UTC (permalink / raw)
  To: Emacs Devel; +Cc: Duy Nguyễn

Ramkumar Ramachandra wrote:
>   #!/bin/sh
>
>   cd /tmp
>   rm -rf z b
>   mkdir z z/a z/b
>   echo ha >z/a/file
>   ln -s z/b
>   cd b
>   cat ../a/file
>   emacs -Q ../a/file # buffer-file-name = /tmp/a/file
>
> Why doesn't emacs behave like cat or vim?  Isn't this behavior a bad default?

Okay, so expand-file-name defined in src/fileio.c is buggy:

  #!/bin/sh

  cd /tmp
  rm -rf z b
  mkdir z z/a z/b
  ln -s z/b
  cd b
  emacs -Q --batch --eval='(error (expand-file-name "../a"))'
  realpath "../a"

Why such horribly convoluted logic? What could be more straightforward?

https://github.com/git/git/blob/master/abspath.c#L34



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BUG] Not following symlinks by default
  2013-07-28 12:02 ` Ramkumar Ramachandra
@ 2013-07-28 18:42   ` Glenn Morris
  2013-07-28 18:50     ` Ramkumar Ramachandra
  0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2013-07-28 18:42 UTC (permalink / raw)
  To: Ramkumar Ramachandra; +Cc: Duy Nguyễn, Emacs Devel


Please note that we have a dedicated bug list. Bugs reported to
emacs-devel have a higher chance of being ignored.
In this case, it sounds like you rediscovered

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8035

I agree it is sub-optimal.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BUG] Not following symlinks by default
  2013-07-28 18:42   ` Glenn Morris
@ 2013-07-28 18:50     ` Ramkumar Ramachandra
  2013-07-30  0:42       ` Glenn Morris
  0 siblings, 1 reply; 5+ messages in thread
From: Ramkumar Ramachandra @ 2013-07-28 18:50 UTC (permalink / raw)
  To: Glenn Morris; +Cc: Duy Nguyễn, Emacs Devel

Glenn Morris wrote:
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8035

Right; last activity in Feb 2011. I'm not interested in reporting
anything: please tell me more about how to fix this bug, and I'll
write the patch now.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BUG] Not following symlinks by default
  2013-07-28 18:50     ` Ramkumar Ramachandra
@ 2013-07-30  0:42       ` Glenn Morris
  0 siblings, 0 replies; 5+ messages in thread
From: Glenn Morris @ 2013-07-30  0:42 UTC (permalink / raw)
  To: Ramkumar Ramachandra; +Cc: Duy Nguyễn, Emacs Devel

Ramkumar Ramachandra wrote:

> Right; last activity in Feb 2011. I'm not interested in reporting
> anything: please tell me more about how to fix this bug, and I'll
> write the patch now.

I don't know how. If I did, I'd comment in the bug report.
I encourage anyone who does to do so.



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-07-30  0:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-28  9:14 [BUG] Not following symlinks by default Ramkumar Ramachandra
2013-07-28 12:02 ` Ramkumar Ramachandra
2013-07-28 18:42   ` Glenn Morris
2013-07-28 18:50     ` Ramkumar Ramachandra
2013-07-30  0:42       ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).