From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Whitespace in `${srcdir}' during `configure' Date: Mon, 10 Nov 2014 12:17:11 -0500 Message-ID: References: <5460673E.8000002@cs.ucla.edu> <83389rnl75.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1415639862 22652 80.91.229.3 (10 Nov 2014 17:17:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Nov 2014 17:17:42 +0000 (UTC) Cc: Eli Zaretskii , eggert@cs.ucla.edu, emacs-devel , Yuri Khan To: Alexander Shukaev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 10 18:17:35 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xnsas-0000d1-IV for ged-emacs-devel@m.gmane.org; Mon, 10 Nov 2014 18:17:34 +0100 Original-Received: from localhost ([::1]:44347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnsas-0007CU-27 for ged-emacs-devel@m.gmane.org; Mon, 10 Nov 2014 12:17:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnsaa-0007BF-JR for emacs-devel@gnu.org; Mon, 10 Nov 2014 12:17:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XnsaW-000736-Lg for emacs-devel@gnu.org; Mon, 10 Nov 2014 12:17:16 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnsaW-000731-J6 for emacs-devel@gnu.org; Mon, 10 Nov 2014 12:17:12 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XnsaV-0005XO-KS; Mon, 10 Nov 2014 12:17:11 -0500 X-Spook: George W. Bush Craig Livingstone CDC digicash X-Ran: gV!kRX>dK5liAXaqAm`J=eGy?{akL,tWHX!<&wM@"w%f*_p6\Bpy`Ddy"JWW$`N0cg1KT! X-Hue: white X-Attribution: GM In-Reply-To: (Alexander Shukaev's message of "Mon, 10 Nov 2014 17:03:12 +0100") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:176697 Archived-At: Alexander Shukaev wrote: > It is relevant. Yesterday I've tried to build it in a directory > "C:\Users\Haroogan\Projects\Bitbucket\Emacs for Windows", where name > corresponds to the name of the project on Bitbucket. Yes, this case occurs > not too often, but directories with spaces are generally allowed and > therefore should be supported. It's an element of build robustness after > all. Just to be clear: building Emacs in a directory with spaces works fine. (Tested with 24.4 tarfile just now on GNU/Linux. There could be some MS Windows specific issue I don't know about.) What doesn't work is passing an explicit srcdir containing spaces to configure. This is something that configure itself rejects. This would be an (odd) out-of-tree build. IMO this is of very minor interest. > My patch at least prevents: > > configure: line 3557: ...: No such file or directory > > And leads to the official error: > > checking whether build environment is sane... configure: error: > unsafe srcdir value: ... But line 3557, which in Emacs 24.4 is . $srcdir/nt/mingw-cfg.site comes _after_ the check for an unsafe srcdir, so how is this sequence possible? But yes, we could certainly quote that one srcdir if it somehow gets accessed before the spaces check. (I see that most of your patch is entirely stylistic, changing $var for ${var}.) > and this limitation might be gone someday. I think we should wait till that day arrives in autotools and make, before worrying about it in Emacs.