From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: master b082371: Change do-not-merge pattern to "do not merge" Date: Tue, 22 Mar 2016 18:28:18 -0400 Message-ID: References: <20160322195727.22320.53641@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458685707 21011 80.91.229.3 (22 Mar 2016 22:28:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Mar 2016 22:28:27 +0000 (UTC) Cc: Paul Eggert To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 22 23:28:27 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aiUmo-0007Ou-2D for ged-emacs-devel@m.gmane.org; Tue, 22 Mar 2016 23:28:26 +0100 Original-Received: from localhost ([::1]:39938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiUmn-0006B0-HX for ged-emacs-devel@m.gmane.org; Tue, 22 Mar 2016 18:28:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiUmj-0006Au-Ru for emacs-devel@gnu.org; Tue, 22 Mar 2016 18:28:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiUmi-0006sQ-N0 for emacs-devel@gnu.org; Tue, 22 Mar 2016 18:28:21 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiUmi-0006sJ-Jl; Tue, 22 Mar 2016 18:28:20 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aiUmg-0001qo-Kv; Tue, 22 Mar 2016 18:28:18 -0400 X-Spook: Israel JUWTF emc event security Blackout condor Secure X-Ran: LDX;A_[c)F.<{@%+lo#]!y@$s0\X!Q,tE.9Xe4R((edvlt5`"M!qTDb}!EMjB|g>1N,deC X-Hue: blue X-Attribution: GM In-Reply-To: (Paul Eggert's message of "Tue, 22 Mar 2016 19:57:28 +0000") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202109 Archived-At: Paul Eggert wrote: > branch: master > commit b08237185ec044c8afff0feb88a126512b33a6d8 > Author: Paul Eggert > Commit: Paul Eggert > > Change do-not-merge pattern to "do not merge" Not broad enough. Should also include "don't merge", "no need to merge", etc. (Unless you think you can get Emacs developers to follow a convention, which history suggests is unlikely.) This pattern needs to err on the side of false positives rather than false negatives; and the person using it needs to think whether to answer yes or no to each "skip" question. (Nothing here has changed since the bzr days.)